All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Jingoo Han <jg1.han@samsung.com>, 'Wim Van Sebroeck' <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org,
	'Guenter Roeck' <linux@roeck-us.net>,
	'Michal Simek' <michal.simek@xilinx.com>
Subject: Re: [PATCH] watchdog: xilinx: Make of_device_id array const
Date: Wed, 07 May 2014 13:24:38 +0200	[thread overview]
Message-ID: <536A17F6.3050006@monstr.eu> (raw)
In-Reply-To: <021701cf69d0$43674870$ca35d950$%han@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

On 05/07/2014 10:42 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/watchdog/of_xilinx_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 57ccae8..1e6e28d 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -225,7 +225,7 @@ static int xwdt_remove(struct platform_device *pdev)
>  }
>  
>  /* Match table for of_platform binding */
> -static struct of_device_id xwdt_of_match[] = {
> +static const struct of_device_id xwdt_of_match[] = {
>  	{ .compatible = "xlnx,xps-timebase-wdt-1.00.a", },
>  	{ .compatible = "xlnx,xps-timebase-wdt-1.01.a", },
>  	{},
> 

Reviewed-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2014-05-07 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  8:42 [PATCH] watchdog: xilinx: Make of_device_id array const Jingoo Han
2014-05-07 11:24 ` Michal Simek [this message]
2014-05-07 12:25 ` Guenter Roeck
2014-05-26 20:10 ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A17F6.3050006@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=jg1.han@samsung.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=michal.simek@xilinx.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.