From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v4 3/9] tools/libxc: Stream specification and some common code Date: Wed, 7 May 2014 13:06:50 +0100 Message-ID: <536A21DA.1020400@citrix.com> References: <1398883012-28413-1-git-send-email-andrew.cooper3@citrix.com> <1398883012-28413-4-git-send-email-andrew.cooper3@citrix.com> <1399463828.13430.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399463828.13430.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Andrew Cooper Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org On 07/05/14 12:57, Ian Campbell wrote: > On Wed, 2014-04-30 at 19:36 +0100, Andrew Cooper wrote: >> diff --git a/tools/libxc/saverestore/stream_format.h b/tools/libxc/saverestore/stream_format.h >> new file mode 100644 >> index 0000000..efcca60 >> --- /dev/null >> +++ b/tools/libxc/saverestore/stream_format.h > > Reference to the spec (which doesn't appear to be in this series > anywhere BTW) > >> @@ -0,0 +1,158 @@ >> +#ifndef __STREAM_FORMAT__H >> +#define __STREAM_FORMAT__H >> + >> +#include >> + >> +/* TODO - find somewhere more appropriate. rec_tsc_info needs it for 64bit */ > > You seem to use it on all of them though. Can we not use explicit > padding, as you seem to do for many of the other structs? Yes, rec_tsc_info needs a trailing uint32_t _res1 field to match the spec. There should be no need to __packed on any of the structures. David