All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
	Konstantin"
	<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dev-VfR2kkLFssw@public.gmane.org"
	<dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH 1/2] ring: introduce rte_ring_get_memsize()
Date: Wed, 07 May 2014 15:04:51 +0200	[thread overview]
Message-ID: <536A2F73.8040300@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFA3F27-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>

Hi Konstantin,

On 05/07/2014 02:35 PM, Ananyev, Konstantin wrote:
> 1. ssize_t rte_ring_get_memsize(unsigned count)
>
> Can you use usual syntax for functions definitions in DPDK:
>
> ssize_t
> rte_ring_get_memsize(unsigned count)
>
> 2. sz = (sz + CACHE_LINE_MASK) & (~CACHE_LINE_MASK);
>
> Use RTE_ALIGN(sz, CACHE_LINE_SIZE) instead?

Thank you for reviewing. I'll include these 2 changes in
a patch-v2.

Regards,
Olivier

  parent reply	other threads:[~2014-05-07 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 11:38 [PATCH 0/2] ring: allow to init a rte_ring outside of an rte_memzone Olivier Matz
     [not found] ` <1399462711-12815-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-07 11:38   ` [PATCH 1/2] ring: introduce rte_ring_get_memsize() Olivier Matz
     [not found]     ` <1399462711-12815-2-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-07 12:35       ` Ananyev, Konstantin
     [not found]         ` <2601191342CEEE43887BDE71AB9772580EFA3F27-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-07 13:04           ` Olivier MATZ [this message]
2014-05-07 11:38   ` [PATCH 2/2] ring: introduce rte_ring_init() Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A2F73.8040300@6wind.com \
    --to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.