All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/qom-test: Test qom-list on link properties
Date: Wed, 07 May 2014 15:06:47 +0200	[thread overview]
Message-ID: <536A2FE7.6020001@suse.de> (raw)
In-Reply-To: <c10e55182b302f87fd4eaf8da001209e6874e4c7.1397253848.git.crobinso@redhat.com>

Am 12.04.2014 00:07, schrieb Cole Robinson:
> But don't test their properties, otherwise we will recurse forever.
> Their properties are already tested when we encounter them as child
> properties elsewhere in the hierarchy, like /machine/unattached/...
> 
> This would have caught the crash fixed by 92b3eead
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  tests/qom-test.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

Sorry, slipped through... Tested and applied now:
https://github.com/afaerber/qemu-cpu/commits/qom-next

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      parent reply	other threads:[~2014-05-07 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 22:07 [Qemu-devel] [PATCH] tests/qom-test: Test qom-list on link properties Cole Robinson
2014-05-06 14:39 ` Cole Robinson
2014-05-07 13:06 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A2FE7.6020001@suse.de \
    --to=afaerber@suse.de \
    --cc=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.