From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: RTE Ring removing
Date: Wed, 07 May 2014 15:08:10 +0200
Message-ID: <536A303A.5040702@6wind.com>
References: <5368A5E0.8090903@arccn.ru> <5369E6AF.4040402@arccn.ru>
 <536A1B5C.2010201@6wind.com> <536A2A44.1030801@arccn.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Igor Ryzhov <iryzhov-p3dJzl6UAic@public.gmane.org>, dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <536A2A44.1030801-p3dJzl6UAic@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Igor,

On 05/07/2014 02:42 PM, Igor Ryzhov wrote:
> But a few questions:
> 1. Will this changes affect performance?

It should not. If you have many rings, you may allocate them
in huge pages to avoid TLB misses.

> 2. In PATCH 2/2 you have a small bug:
>
> In file rte_ring.h, in comments describing rte_ring_init function you have:
>
> + * @param name
> + *   The size of the ring.
>
> But it is name of the ring, not size.

Thank you for this comment, I'll fix it in the v2.

Regards,
Olivier