All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode'
Date: Wed, 07 May 2014 16:01:53 +0100	[thread overview]
Message-ID: <536A4AE1.6080500@redhat.com> (raw)
In-Reply-To: <1188155073.2089872.1399474082928.JavaMail.zimbra@redhat.com>

On 07/05/14 15:48, Bob Peterson wrote:
> ----- Original Message -----
>> mkfs.gfs2 and gfs2_jadd used struct gfs2_sbd.expert to put them into an
>> undocumented 'expert mode' but didn't really do anything useful in that
>> mode. Remove that field and other 'expert' references.
>>
>
> In the past, we've used mkfs.gfs2 expert mode to create certain test
> conditions, like very small resource groups. I don't think Nate uses
> this in any of his tests, but it might be worth asking.
> I've used it to try to recreate certain failing scenarios, but I haven't
> needed it in years. Are we sure we want to get rid of it?

I don't think we'd get much value out of testing resource group sizes 
which are technically unsupported. The resource group size validation 
and selection bits have all changed anyway and it doesn't really make 
sense any more. If it turns out there's a real use case for something 
like this then maybe we can add it back or implement a more focused 
solution.

Andy



  reply	other threads:[~2014-05-07 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 14:33 [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode' Andrew Price
2014-05-07 14:48   ` Bob Peterson
2014-05-07 15:01     ` Andrew Price [this message]
2014-05-07 14:33 ` [Cluster-devel] [PATCH 3/5] libgfs2: Remove UI fields from struct gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 4/5] libgfs2: Remove debug field from gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API Andrew Price
2014-05-07 14:48   ` Steven Whitehouse
2014-05-07 14:55   ` Bob Peterson
2014-05-07 15:07     ` Andrew Price
2014-05-07 15:17       ` Andrew Price
2014-05-07 14:39 ` [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit Steven Whitehouse
2014-05-07 15:15   ` Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A4AE1.6080500@redhat.com \
    --to=anprice@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.