From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Wed, 07 May 2014 16:01:53 +0100 Subject: [Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode' In-Reply-To: <1188155073.2089872.1399474082928.JavaMail.zimbra@redhat.com> References: <1399473221-28521-1-git-send-email-anprice@redhat.com> <1399473221-28521-2-git-send-email-anprice@redhat.com> <1188155073.2089872.1399474082928.JavaMail.zimbra@redhat.com> Message-ID: <536A4AE1.6080500@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 07/05/14 15:48, Bob Peterson wrote: > ----- Original Message ----- >> mkfs.gfs2 and gfs2_jadd used struct gfs2_sbd.expert to put them into an >> undocumented 'expert mode' but didn't really do anything useful in that >> mode. Remove that field and other 'expert' references. >> > > In the past, we've used mkfs.gfs2 expert mode to create certain test > conditions, like very small resource groups. I don't think Nate uses > this in any of his tests, but it might be worth asking. > I've used it to try to recreate certain failing scenarios, but I haven't > needed it in years. Are we sure we want to get rid of it? I don't think we'd get much value out of testing resource group sizes which are technically unsupported. The resource group size validation and selection bits have all changed anyway and it doesn't really make sense any more. If it turns out there's a real use case for something like this then maybe we can add it back or implement a more focused solution. Andy