From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Wed, 7 May 2014 09:14:05 -0700 Subject: [U-Boot] [PATCH 12/12] imx: ventana: switch to SPL In-Reply-To: References: <1398716258-8420-1-git-send-email-tharvey@gateworks.com> <1398716258-8420-13-git-send-email-tharvey@gateworks.com> <1399403502.2123.11.camel@yellow> Message-ID: <536A5BCD.9070406@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/06/2014 04:35 PM, Tim Harvey wrote: > On Tue, May 6, 2014 at 12:11 PM, Jeroen Hofstee wrote: >> Hello Tim, >> >> >> Since Crt0.S already created gd on the stack before calling >> board_init_f, can't the assignment of gd not simply be removed? >> Is there anything special about gdata? >> >> Regards, >> Jeroen >> >> > > Jeroen, > > That does make sense, but what I find is that York's ocmmit > dec1861be90c948ea9fb771927d3d26a994d2e20 requires that gd be blanked > and its not. This causes bus_i2c_init to skip its initialization > because p->base is not zero. > > York, does this make sense? Your patch creates a dependence on > gd->srdata being blank which isn't the case with the SRAM when booting > from the IMX6 boot rom. > GD should be cleared (zeroed). Then we don't have this problem. Whoever sets up gd (board_int_f, cpu_init_f, or others) should make sure gd is cleared. Why isn't it the case for IMX6 boot rom? York