Re: [PATCH v2 1/1] he910: reset modem after IO disconnect

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Hi Jonas,

<snip>
>
> This patch also addresses a secondary issue whereby killing ofono during
> an active connection causes the AUX port to report HUP when ofono is
> restarted.
> 

I'm not quite sure how this patch would fix the above.  The order of
events is the same between kill/restart and a modem reset.  I guess the
only difference is that you don't send a CFUN=4 during a modem reset.

> How about this approach instead?  Using ofono_modem_reset has pretty
> much the same effect as my previous patch and _feels" correct...

ofono_modem_reset is intended for firmware crashes and getting back to
previous state quickly.  This is a creative hack, but has some
side-effects you might not intend (e.g. the modem might go online
without being told explicitly)

I don't really mind the patch, but would explore the 'proper' avenues
(e.g. ofono_sim_inserted_notify) first.

Regards,
-Denis