From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] mmc: provide a select_hwpart implementation for get_device()
Date: Wed, 07 May 2014 12:27:56 -0600 [thread overview]
Message-ID: <536A7B2C.2020507@wwwdotorg.org> (raw)
In-Reply-To: <CAOMZO5AJY-1D4LjrwL9FJPRML2CJqrfpaoQrWP0qDtwUaMjSHQ@mail.gmail.com>
On 05/07/2014 12:22 PM, Fabio Estevam wrote:
> On Wed, May 7, 2014 at 3:19 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> +int mmc_select_hwpart(int dev_num, int hwpart)
...
>> + ret = mmc_switch_part(dev_num, hwpart);
>> + if (ret)
>> + return -1;
>
> Can't you return more appropriate return values rather than -1?
Oh yes, I should return ret there. I'll hold off for a while before
posting V2 though.
next prev parent reply other threads:[~2014-05-07 18:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 18:19 [U-Boot] [PATCH 1/4] cmd_part: fix type in part command help text Stephen Warren
2014-05-07 18:19 ` [U-Boot] [PATCH 2/4] disk: support devices with HW partitions Stephen Warren
2014-05-23 9:09 ` Pantelis Antoniou
2014-05-07 18:19 ` [U-Boot] [PATCH 3/4] mmc: provide a select_hwpart implementation for get_device() Stephen Warren
2014-05-07 18:22 ` Fabio Estevam
2014-05-07 18:27 ` Stephen Warren [this message]
2014-05-23 9:21 ` Pantelis Antoniou
2014-05-23 15:58 ` Stephen Warren
2014-05-23 16:02 ` Pantelis Antoniou
2014-05-07 18:19 ` [U-Boot] [PATCH 4/4] cmd_mmc: use new mmc_select_hwpart() function Stephen Warren
2014-05-23 9:24 ` Pantelis Antoniou
2014-05-23 16:45 ` Stephen Warren
2014-05-14 17:30 ` [U-Boot] [PATCH 1/4] cmd_part: fix type in part command help text Stephen Warren
2014-05-14 21:17 ` Tom Rini
2014-05-14 21:29 ` Pantelis Antoniou
2014-05-22 23:30 ` Stephen Warren
2014-05-23 9:02 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A7B2C.2020507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.