All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stanislav Vorobiov <s.vorobiov@samsung.com>, qemu-devel@nongnu.org
Cc: alex@alex.org.uk, sw@weilnetz.de, sangho1206.park@samsung.com,
	stefanha@redhat.com, syeon.hwang@samsung.com,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] glib: fix g_poll early timeout on windows
Date: Thu, 08 May 2014 12:19:29 +0400	[thread overview]
Message-ID: <536B3E11.5090206@msgid.tls.msk.ru> (raw)
In-Reply-To: <536A28CF.6030101@samsung.com>

07.05.2014 16:36, Stanislav Vorobiov wrote:
> Hi,
> 
> IMHO it's not a problem, automerge will resolve this

Now the trivial queue pull request has been processed, some
of this patch is in the tree.  I don't know what is this
magic "automerge" which you're talking about.  The thing
is that your code is a bit different (for one, it wraps
g_poll() definition in glib-compat.h into #ifdef WIN32,
for another it adds g_poll_fixed()), and the patch
does not apply anymore.

I'd suggest you to rebase and resubmit.  Hopefully it wont
clash with further glib-compat additions which are on the
way.

Thank you!

/mjt

      reply	other threads:[~2014-05-08  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  9:07 [Qemu-devel] [PATCH v4] glib: fix g_poll early timeout on windows Stanislav Vorobiov
2014-05-07 12:21 ` Michael Tokarev
2014-05-07 12:36   ` Stanislav Vorobiov
2014-05-08  8:19     ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536B3E11.5090206@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=alex@alex.org.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=s.vorobiov@samsung.com \
    --cc=sangho1206.park@samsung.com \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=syeon.hwang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.