From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJrS-0004sN-3p
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:39:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WiJrK-0001qC-JG
	for qemu-devel@nongnu.org; Thu, 08 May 2014 04:39:26 -0400
Message-ID: <536B42B5.5040300@suse.de>
Date: Thu, 08 May 2014 10:39:17 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1399537603-6905-1-git-send-email-dougkwan@google.com>
	<1399537603-6905-3-git-send-email-dougkwan@google.com>
In-Reply-To: <1399537603-6905-3-git-send-email-dougkwan@google.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Doug Kwan <dougkwan@google.com>
Cc: riku.voipio@iki.fi, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 05/08/2014 10:26 AM, Doug Kwan wrote:
> This all running PPC64 little-endian in user mode if target is configured
> that way.  In PPC64 LE user mode we set MSR.LE during initialization.
> Byteswapping logic is reversed also when QEMU is running in that mode.
>
> Signed-off-by: Doug Kwan <dougkwan@google.com>

I can't say I'm a huge fan of this patch. It allows for really tricky 
subtile mistakes to happen. Can't we leave the target mode configured on 
big endian?


Alex