From: Bob Liu <bob.liu@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Bob Liu <lliubbo@gmail.com>,
keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com,
stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 3/3] tmem: fix Out-of-bounds read reported by Coverity
Date: Thu, 08 May 2014 16:47:42 +0800 [thread overview]
Message-ID: <536B44AE.40401@oracle.com> (raw)
In-Reply-To: <536A0C04020000780000FBE1@mail.emea.novell.com>
On 05/07/2014 04:33 PM, Jan Beulich wrote:
>>>> On 07.05.14 at 08:30, <lliubbo@gmail.com> wrote:
>> CID 1198729, CID 1198730 and CID 1198734 complain about
>> "Out-of-bounds read".
>>
>> This patch fixes them by casting the 'firstbyte' to (uint8_t), some
>> unnecessary assertion also be dropped.
>>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> It looks to me as if the code was more correct without these changes,
> and doing these changes just to work around a pretty obvious
> Coverity flaw seems rather odd.
>
Okay, then please consider merge 1/3 and 2/3.
--
Regards,
-Bob
next prev parent reply other threads:[~2014-05-08 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 6:30 [PATCH v2 1/3] xc/tmem: Free temporary buffer used during migration Bob Liu
2014-05-07 6:30 ` [PATCH v2 2/3] xc/tmem: Unchecked return value Bob Liu
2014-05-08 8:47 ` Bob Liu
2014-05-07 6:30 ` [PATCH v2 3/3] tmem: fix Out-of-bounds read reported by Coverity Bob Liu
2014-05-07 8:33 ` Jan Beulich
2014-05-08 8:47 ` Bob Liu [this message]
2014-05-07 8:26 ` [PATCH v2 1/3] xc/tmem: Free temporary buffer used during migration Jan Beulich
2014-05-08 8:46 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B44AE.40401@oracle.com \
--to=bob.liu@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=lliubbo@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.