From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiL7i-00019v-1P for qemu-devel@nongnu.org; Thu, 08 May 2014 06:00:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiL7a-0005b2-IC for qemu-devel@nongnu.org; Thu, 08 May 2014 06:00:17 -0400 Message-ID: <536B55A9.6020708@suse.de> Date: Thu, 08 May 2014 12:00:09 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1399212588-23304-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1399212588-23304-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 05/04/2014 04:09 PM, Alexey Kardashevskiy wrote: > At the moment XICS does not support interrupts reuse so sPAPR PHB > implements this. sPAPRPHBState holds array of 32 spapr_pci_msi to > describe PCI config address, first MSI and number of MSIs. Once > allocated for a device, QEMU tries reusing this config until the number > of MSIs changes. > > Existing SPAPR guests call ibm,change-msi in a loop until the handler > returns the requested number of vectors. > > Recently introduced check for the maximum number of MSI/MSIX vectors > supported by a device only works for a device which is new for PHB's > MSI cache. If it is already there, the check is not performed which > leads to new IRQ block allocation. This happens during PCI hotplug > even when the user hot plug the same device which he just hot unplugged. > > This moves the check earlier. > > Signed-off-by: Alexey Kardashevskiy Thanks, applied to ppc-next. Alex