From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 08 May 2014 10:06:59 +0000 Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr Message-Id: <536B5743.2060708@suse.de> List-Id: References: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Aneesh Kumar K.V" Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote: > Although it's optional IBM POWER cpus always had DAR value set on > alignment interrupt. So don't try to compute these values. > > Signed-off-by: Aneesh Kumar K.V The patch body is fine now. The commit message however is not. The patch does two things: * Merge DSISR calculation with Linux's implementation * Use the real DAR on book3s_64 alignment interrupts In fact, you probably should make this 2 patches. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 03FC114008E for ; Thu, 8 May 2014 20:07:04 +1000 (EST) Message-ID: <536B5743.2060708@suse.de> Date: Thu, 08 May 2014 12:06:59 +0200 From: Alexander Graf MIME-Version: 1.0 To: "Aneesh Kumar K.V" Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr References: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote: > Although it's optional IBM POWER cpus always had DAR value set on > alignment interrupt. So don't try to compute these values. > > Signed-off-by: Aneesh Kumar K.V The patch body is fine now. The commit message however is not. The patch does two things: * Merge DSISR calculation with Linux's implementation * Use the real DAR on book3s_64 alignment interrupts In fact, you probably should make this 2 patches. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH V5] KVM: PPC: BOOK3S: Use the saved dar value and generic make_dsisr Date: Thu, 08 May 2014 12:06:59 +0200 Message-ID: <536B5743.2060708@suse.de> References: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: In-Reply-To: <1399386622-21407-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/06/2014 04:30 PM, Aneesh Kumar K.V wrote: > Although it's optional IBM POWER cpus always had DAR value set on > alignment interrupt. So don't try to compute these values. > > Signed-off-by: Aneesh Kumar K.V The patch body is fine now. The commit message however is not. The patch does two things: * Merge DSISR calculation with Linux's implementation * Use the real DAR on book3s_64 alignment interrupts In fact, you probably should make this 2 patches. Alex