From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <cwang@twopensource.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev <netdev@vger.kernel.org>, d77190@mail.ru
Subject: Re: Fw: [Bug 75571] New: using tc action mirred results BUG at net/core/skbuff.c:119
Date: Thu, 08 May 2014 06:13:43 -0400 [thread overview]
Message-ID: <536B58D7.2070009@mojatatu.com> (raw)
In-Reply-To: <CAHA+R7NX639wxkvvrqP=ogeiAwDeJYDnFp_z_VqB3yqh8KLjFA@mail.gmail.com>
Hi Cong,
Sorry for the latency - on travel mode.
On 05/06/14 18:30, Cong Wang wrote:
> On Tue, May 6, 2014 at 8:16 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>
> Hmm, looks like we pushed wrong header size here. tcf_mirred_init()
> checks if we could push hard header by checking the type of the target device,
> while in tcf_mirred() we push the ->hard_header_len of the source device
> where this skb is received. I am not sure at all.
>
> Jamal, does the following patch make any sense for you?
>
Dont feel like that patch would help. Scratching my head....
One way to tell is to: ifconfig down the source (which seems like tunnel
device) and install all the rules then last step is ifconfig first ifb,
then the tunnel device. And if it works with current kernel patch is not
needed. It feels like some race condition between installing
rule and using it i.e rule gets installed and when still trying to
advertise to user space, a packet arrives and starts using it.
If the above works - then the question to d77190@mail.ru is what kernel
this is and when did this last work as installed?
[My gut feeling is it may have something to do with the rcu changes
perhaps - but not sure.]
cheers,
jamal
next prev parent reply other threads:[~2014-05-08 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 15:16 Fw: [Bug 75571] New: using tc action mirred results BUG at net/core/skbuff.c:119 Stephen Hemminger
2014-05-06 22:30 ` Cong Wang
2014-05-08 10:13 ` Jamal Hadi Salim [this message]
2014-05-09 18:31 ` Cong Wang
2014-05-11 11:29 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B58D7.2070009@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=cwang@twopensource.com \
--cc=d77190@mail.ru \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.