From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] clarify SHUTDOWN_suspend additional argument Date: Thu, 8 May 2014 11:46:25 +0100 Message-ID: <536B6081.9010508@citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xensource.com Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org On 07/05/14 14:05, Stefano Stabellini wrote: > SCHEDOP_shutdown has a third argument that is unused on HVM and ARM > guests. Those guests pass 0 instead. Clarify the behaviour in the > hypercall description. > > Signed-off-by: Stefano Stabellini > > diff --git a/xen/include/public/sched.h b/xen/include/public/sched.h > index a30b11d..c170556 100644 > --- a/xen/include/public/sched.h > +++ b/xen/include/public/sched.h > @@ -77,8 +77,9 @@ > * @arg == pointer to sched_shutdown_t structure. > * > * If the sched_shutdown_t reason is SHUTDOWN_suspend then this > - * hypercall takes an additional extra argument which should be the > - * MFN of the guest's start_info_t. > + * hypercall takes an additional extra argument which should be: > + * - the MFN of the guest's start_info_t for x86 PV guests; > + * - 0 for x86 HVM guests and arm and arm64 guests. Perhaps word this to reflect what the toolstack actually does? * x86 PV guest must also set RDX (EDX for 32-bit guests) to the MFN * of the guest's start info page. RDX/EDX is the third hypercall * argument. David