From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] ARM: dts: enable pwm backlight on exynos5250-snow Date: Thu, 08 May 2014 13:52:58 +0200 Message-ID: <536B701A.40209@samsung.com> References: <1399467371-12242-1-git-send-email-ajaykumar.rs@samsung.com> <536A98E7.9030007@gmail.com> <536A9C82.6090704@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:20438 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261AbaEHLxE (ORCPT ); Thu, 8 May 2014 07:53:04 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N59005J97O875A0@mailout4.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 08 May 2014 12:52:56 +0100 (BST) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Ajay kumar , Tomasz Figa Cc: Ajay Kumar , "linux-samsung-soc@vger.kernel.org" , Kukjin Kim , sunil joshi , Prashanth G , Olof Johansson On 08.05.2014 11:54, Ajay kumar wrote: > Tomasz, > > On Thu, May 8, 2014 at 2:20 AM, Tomasz Figa wrote: >> On 07.05.2014 22:47, Ajay kumar wrote: >>> >>> Tomasz, >>> >>> On Thu, May 8, 2014 at 2:04 AM, Tomasz Figa wrote: >>>> >>>> Hi Ajay, >>>> >>>> >>>> On 07.05.2014 14:56, Ajay Kumar wrote: >>>>> >>>>> >>>>> Add PWM backlight node for exynos5250 and enable the same on exynos5250 >>>>> based snow board. >>>>> >>>>> Signed-off-by: Olof Johansson >>>>> Signed-off-by: Ajay Kumar >>>>> --- >>>>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++ >>>>> arch/arm/boot/dts/exynos5250-snow.dts | 5 +++++ >>>>> arch/arm/boot/dts/exynos5250.dtsi | 10 ++++++++++ >>>>> 3 files changed, 22 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>>>> b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>>>> index 9a49e68..2a4680c 100644 >>>>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>>>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>>>> @@ -351,6 +351,13 @@ >>>>> samsung,pin-drv = <0>; >>>>> }; >>>>> >>>>> + backlight_pwm: backlight-pwm { >>>>> + samsung,pins = "gpb2-0"; >>>>> + samsung,pin-function = <2>; >>>>> + samsung,pin-pud = <0>; >>>>> + samsung,pin-drv = <0>; >>>>> + }; >>>> >>>> >>>> >>>> This looks like a generic PWM output function, not specific to backlight >>>> in >>>> any way. >>>> >>>> Please see patch [1] adding PWM output pin groups for Exynos5420 for >>>> reference. >>>> >>>> [1] >>>> >>>> https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg29869.html >>> >>> Right! I just referred to the manual again, and it actually reads TOUT_0. >>> So, I should be probably renaming this as "pwm0_out" like in the other >>> patch? >> >> >> Yes, please. You should also add remaining ones, while at it. Basically same >> patch as [1] but for Exynos5250. > > Sent "[PATCH 1/2] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5250" Thanks. Best regards, Tomasz