diff for duplicates of <536B712F.70707@huawei.com> diff --git a/a/1.txt b/N1/1.txt index 3d15936..12db0ec 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,7 +19,7 @@ On 2014/5/8 19:41, Neil Horman wrote: >>>>> } >>>>> >>>>> net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table); ->>>>> + if (net->sctp.sysctl_header = NULL) { +>>>>> + if (net->sctp.sysctl_header == NULL) { >>>>> + if (!net_eq(net, &init_net)) >>>>> + kfree(table); >>>>> + return -ENOMEM; @@ -52,7 +52,7 @@ On 2014/5/8 19:41, Neil Horman wrote: Hm, Should I add this: -+ if (net->sctp.sysctl_header = NULL); ++ if (net->sctp.sysctl_header == NULL); + kfree(table); to the revert patch or do a new patch? diff --git a/a/content_digest b/N1/content_digest index ad77c12..da35d83 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,13 +5,13 @@ "ref\020140508114124.GD9696@hmsreliant.think-freely.org\0" "From\0Wang Weidong <wangweidong1@huawei.com>\0" "Subject\0Re: [PATCH net-next] sctp: add a checking for sctp_sysctl_net_register\0" - "Date\0Thu, 08 May 2014 11:57:35 +0000\0" + "Date\0Thu, 8 May 2014 19:57:35 +0800\0" "To\0Neil Horman <nhorman@tuxdriver.com>\0" "Cc\0David Miller <davem@davemloft.net>" Vlad Yasevich <vyasevich@gmail.com> Daniel Borkmann <dborkman@redhat.com> - linux-sctp@vger.kernel.org - " netdev@vger.kernel.org\0" + <linux-sctp@vger.kernel.org> + " <netdev@vger.kernel.org>\0" "\00:1\0" "b\0" "On 2014/5/8 19:41, Neil Horman wrote:\n" @@ -35,7 +35,7 @@ ">>>>> \t}\n" ">>>>> \n" ">>>>> \tnet->sctp.sysctl_header = register_net_sysctl(net, \"net/sctp\", table);\n" - ">>>>> +\tif (net->sctp.sysctl_header = NULL) {\n" + ">>>>> +\tif (net->sctp.sysctl_header == NULL) {\n" ">>>>> +\t\tif (!net_eq(net, &init_net))\n" ">>>>> +\t\t\tkfree(table);\n" ">>>>> +\t\treturn -ENOMEM;\n" @@ -68,7 +68,7 @@ "\n" "Hm, Should I add this:\n" "\n" - "+\tif (net->sctp.sysctl_header = NULL);\n" + "+\tif (net->sctp.sysctl_header == NULL);\n" "+\t\tkfree(table);\n" "\n" "to the revert patch or do a new patch?\n" @@ -105,4 +105,4 @@ "> .\n" > -1e083589b74a41295de4125280aa1b474babc297b0cdf6ed2582f6226be0628f +60365db1fd9d4ef1f80146dbea1270738795ad2a12615edcd8dd402f22eeb032
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.