From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiNfz-0000bt-MO for qemu-devel@nongnu.org; Thu, 08 May 2014 08:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiNfu-0003NR-9q for qemu-devel@nongnu.org; Thu, 08 May 2014 08:43:51 -0400 Received: from fldsmtpe04.verizon.com ([140.108.26.143]:61646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiNfu-0003NM-2a for qemu-devel@nongnu.org; Thu, 08 May 2014 08:43:46 -0400 From: Don Slutz Message-ID: <536B7BEC.2020803@terremark.com> Date: Thu, 08 May 2014 08:43:24 -0400 MIME-Version: 1.0 References: <1399400197-7180-1-git-send-email-ncmike@ncultra.org> In-Reply-To: <1399400197-7180-1-git-send-email-ncmike@ncultra.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day , qemu-devel@nongnu.org Cc: blauwirbel@gmail.com On 05/06/14 14:16, Mike Day wrote: > This updates scripts/checkpatch.pl to version 0.32. Also, > forward-ported the QEMU checks for no tabs and correct capitalization > of "QEMU." Finally, make --no-tree the default option since this will > be used with Qemu. > > Signed-off-by: Mike Day > --- > > Notes: This is a huge patch and I needed to include white space > changes to get it applying cleanly. > > I've tested this so far with some random patches off the mailing list > and some others that I've got around. I also tested for some intentional > errors. > > scripts/checkpatch.pl | 2544 ++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 2120 insertions(+), 424 deletions(-) > > I have used to following to see how a new version compares: k=500;i=0;j=0;for sha in $(git log --no-merges --format=format:"%h" -$k);do let i=$i+1; git show $sha >/tmp/a; clear;echo $i;head -20 /tmp/a; ./scripts/checkpatch.pl --root=. /tmp/a; err=$?; if [ $err != 0 ]; then let j=$j+1;read foo;fi; done;echo Check $i, Bad $j ... total: 0 errors, 0 warnings, 79 lines checked /tmp/a has no obvious style problems and is ready for submission. Check 500, Bad 52 -Don Slutz