From: Andreas Larsson <andreas@gaisler.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>, Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext()
Date: Thu, 08 May 2014 15:01:48 +0200 [thread overview]
Message-ID: <536B803C.3000706@gaisler.com> (raw)
In-Reply-To: <1399494412-27056-1-git-send-email-khoroshilov@ispras.ru>
On 2014-05-07 22:26, Alexey Khoroshilov wrote:
> As far as gr_queue() is called with spinlock held,
> we have to pass GFP_ATOMIC regardless of gfp argument.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Andreas Larsson <andreas@gaisler.com>
> ---
> drivers/usb/gadget/gr_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
> index f984ee75324d..19a1b52c4210 100644
> --- a/drivers/usb/gadget/gr_udc.c
> +++ b/drivers/usb/gadget/gr_udc.c
> @@ -1679,7 +1679,7 @@ static int gr_queue_ext(struct usb_ep *_ep, struct usb_request *_req,
> if (ep->is_in)
> gr_dbgprint_request("EXTERN", ep, req);
>
> - ret = gr_queue(ep, req, gfp_flags);
> + ret = gr_queue(ep, req, GFP_ATOMIC);
>
> spin_unlock(&ep->dev->lock);
>
>
prev parent reply other threads:[~2014-05-08 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 20:26 [PATCH] usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext() Alexey Khoroshilov
2014-05-08 13:01 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B803C.3000706@gaisler.com \
--to=andreas@gaisler.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.