All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups
Date: Thu, 08 May 2014 17:33:33 +0400	[thread overview]
Message-ID: <536B87AD.3040305@msgid.tls.msk.ru> (raw)
In-Reply-To: <536B867C.8040303@redhat.com>

08.05.2014 17:28, Paolo Bonzini wrote:
> Il 08/05/2014 15:16, Michael Tokarev ha scritto:
>> However, I still (in combined result of the 2 patches) miss one little detail
>> about libcacard and this stuff, which this patch also does a bit wrong.
>>
>> $(NSS_LIBS) is not a dependency of hw/usb/ccid-card-emulated.o, it is a
>> dependency of libcacard/vcard_emul_nss.o - the only single file in whole
>> qemu tree which actually uses nss stuff.  Hopefully, it works after the
>> per-object -libs fixup patch.. ;)
> 
> You're obviously right and yes, it works giving this overall patch:

The same as I commited a few mins ago.  But with a fixme for now
in vcard_emul_nss.o-libs place (as I need to keep it working in
my tree too).

http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-buildsys-libs

Thanks,

/mjt

      reply	other threads:[~2014-05-08 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 13:08 [Qemu-devel] [PATCH 0/2] build: simplify and fix fix-obj-vars, more libcacard cleanups Paolo Bonzini
2014-05-08 13:08 ` [Qemu-devel] [PATCH 1/2] build: simplify and fix fix-obj-vars Paolo Bonzini
2014-05-08 13:40   ` Fam Zheng
2014-05-08 14:39     ` Paolo Bonzini
2014-05-08 13:08 ` [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups Paolo Bonzini
2014-05-08 13:16   ` Michael Tokarev
2014-05-08 13:28     ` Paolo Bonzini
2014-05-08 13:33       ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536B87AD.3040305@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.