From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v6] Autoconf: add variable for pass arbitrary options to qemu upstream Date: Thu, 08 May 2014 12:53:24 -0400 Message-ID: <536BB684.3010909@terremark.com> References: <1399386650-22288-1-git-send-email-fabio.fantoni@m2r.biz> <1399542811.9513.21.camel@kazak.uk.xensource.com> <536B63D8.2030105@m2r.biz> <1399549411.9513.75.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399549411.9513.75.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Fabio Fantoni Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Stefano.Stabellini@eu.citrix.com, Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On 05/08/14 07:43, Ian Campbell wrote: > On Thu, 2014-05-08 at 13:00 +0200, Fabio Fantoni wrote: >> Il 08/05/2014 11:53, Ian Campbell ha scritto: >>> On Tue, 2014-05-06 at 16:30 +0200, Fabio Fantoni wrote: >>>> Added configure options for pass arbitrary build options to qemu >>>> upstream. >>>> >>>> Usage example: >>>> ./configure QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" >>> Isn't >>> ./configure --with-extra-qemuu-configure-args="--enable-sss" >>> more conventional for this sort of thing? >> I don't know, tell me what is best. Sorry I missed early versions of this. There is no reason that I know of to involve configure in this. The following works just fine (Just the makefile change and a changed commit message): From 847b9dee4dea17c86f6ec402e5fcff7d515d1767 Mon Sep 17 00:00:00 2001 From: Fabio Fantoni Date: Tue, 6 May 2014 16:30:50 +0200 Subject: [PATCH] tools: Pass arbitrary build options to qemu upstream. Usage examples: CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" make tools or make tools CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" or echo CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" >>.config make tools or export CONFIG_QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir" make tools Signed-off-by: Fabio Fantoni --- tools/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/Makefile b/tools/Makefile index 3675515..992fe3e 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -203,6 +203,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find --disable-docs \ --disable-guest-agent \ --python=$(PYTHON) \ + $(CONFIG_QEMUU_EXTRA_ARGS) \ $(IOEMU_CONFIGURE_CROSS); \ $(MAKE) all -- 1.8.2.1