* [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420
@ 2014-05-08 10:53 ` Vikas Sajjan
0 siblings, 0 replies; 4+ messages in thread
From: Vikas Sajjan @ 2014-05-08 10:53 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc
Cc: kgene.kim, tomasz.figa, joshi, pankaj.dubey, Vikas Sajjan
Adds clk save/restore registers for 5420
Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
drivers/clk/samsung/clk-exynos5420.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index 60b2681..01fd917 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -101,6 +101,18 @@
#define KPLL_CON0 0x28100
#define SRC_KFC 0x28200
#define DIV_KFC0 0x28500
+#define SRC_MASK_CPERI 0x04300
+#define SRC_MASK_TOP0 0x10300
+#define SRC_MASK_TOP1 0x10304
+#define SRC_MASK_TOP2 0x10308
+#define SRC_MASK_TOP7 0x1031C
+#define SRC_MASK_MAU 0x10334
+#define SRC_MASK_FSYS 0x10340
+#define SRC_MASK_PERIC0 0x10350
+#define SRC_MASK_PERIC1 0x10354
+#define SRC_MASK_ISP 0x10370
+#define GATE_BUS_DISP1 0x10728
+#define GATE_IP_PERIC 0x10950
/* list of PLLs */
enum exynos5420_plls {
@@ -180,11 +192,29 @@ static unsigned long exynos5420_clk_regs[] __initdata = {
DIV_KFC0,
};
+static const struct samsung_clk_reg_dump exynos5420_set_clksrc[] = {
+ { .offset = SRC_MASK_CPERI, .value = 0xffffffff, },
+ { .offset = SRC_MASK_TOP0, .value = 0x11111111, },
+ { .offset = SRC_MASK_TOP1, .value = 0x11101111, },
+ { .offset = SRC_MASK_TOP2, .value = 0x11111110, },
+ { .offset = SRC_MASK_TOP7, .value = 0x00111100, },
+ { .offset = SRC_MASK_DISP10, .value = 0x11111110, },
+ { .offset = SRC_MASK_MAU, .value = 0x10000000, },
+ { .offset = SRC_MASK_FSYS, .value = 0x11111110, },
+ { .offset = SRC_MASK_PERIC0, .value = 0x11111110, },
+ { .offset = SRC_MASK_PERIC1, .value = 0x11111100, },
+ { .offset = SRC_MASK_ISP, .value = 0x11111000, },
+ { .offset = GATE_BUS_DISP1, .value = 0xffffffff, },
+ { .offset = GATE_IP_PERIC, .value = 0xffffffff, },
+};
+
static int exynos5420_clk_suspend(void)
{
samsung_clk_save(reg_base, exynos5420_save,
ARRAY_SIZE(exynos5420_clk_regs));
+ samsung_clk_restore(reg_base, exynos5420_set_clksrc,
+ ARRAY_SIZE(exynos5420_set_clksrc));
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420
@ 2014-05-08 10:53 ` Vikas Sajjan
0 siblings, 0 replies; 4+ messages in thread
From: Vikas Sajjan @ 2014-05-08 10:53 UTC (permalink / raw)
To: linux-arm-kernel
Adds clk save/restore registers for 5420
Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
drivers/clk/samsung/clk-exynos5420.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index 60b2681..01fd917 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -101,6 +101,18 @@
#define KPLL_CON0 0x28100
#define SRC_KFC 0x28200
#define DIV_KFC0 0x28500
+#define SRC_MASK_CPERI 0x04300
+#define SRC_MASK_TOP0 0x10300
+#define SRC_MASK_TOP1 0x10304
+#define SRC_MASK_TOP2 0x10308
+#define SRC_MASK_TOP7 0x1031C
+#define SRC_MASK_MAU 0x10334
+#define SRC_MASK_FSYS 0x10340
+#define SRC_MASK_PERIC0 0x10350
+#define SRC_MASK_PERIC1 0x10354
+#define SRC_MASK_ISP 0x10370
+#define GATE_BUS_DISP1 0x10728
+#define GATE_IP_PERIC 0x10950
/* list of PLLs */
enum exynos5420_plls {
@@ -180,11 +192,29 @@ static unsigned long exynos5420_clk_regs[] __initdata = {
DIV_KFC0,
};
+static const struct samsung_clk_reg_dump exynos5420_set_clksrc[] = {
+ { .offset = SRC_MASK_CPERI, .value = 0xffffffff, },
+ { .offset = SRC_MASK_TOP0, .value = 0x11111111, },
+ { .offset = SRC_MASK_TOP1, .value = 0x11101111, },
+ { .offset = SRC_MASK_TOP2, .value = 0x11111110, },
+ { .offset = SRC_MASK_TOP7, .value = 0x00111100, },
+ { .offset = SRC_MASK_DISP10, .value = 0x11111110, },
+ { .offset = SRC_MASK_MAU, .value = 0x10000000, },
+ { .offset = SRC_MASK_FSYS, .value = 0x11111110, },
+ { .offset = SRC_MASK_PERIC0, .value = 0x11111110, },
+ { .offset = SRC_MASK_PERIC1, .value = 0x11111100, },
+ { .offset = SRC_MASK_ISP, .value = 0x11111000, },
+ { .offset = GATE_BUS_DISP1, .value = 0xffffffff, },
+ { .offset = GATE_IP_PERIC, .value = 0xffffffff, },
+};
+
static int exynos5420_clk_suspend(void)
{
samsung_clk_save(reg_base, exynos5420_save,
ARRAY_SIZE(exynos5420_clk_regs));
+ samsung_clk_restore(reg_base, exynos5420_set_clksrc,
+ ARRAY_SIZE(exynos5420_set_clksrc));
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420
2014-05-08 10:53 ` Vikas Sajjan
@ 2014-05-08 17:18 ` Tomasz Figa
-1 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-05-08 17:18 UTC (permalink / raw)
To: Vikas Sajjan, linux-arm-kernel, linux-samsung-soc
Cc: kgene.kim, tomasz.figa, joshi, pankaj.dubey
Hi Vikas,
Please try to more or less follow subsystem subject conventions. It
should be:
clk: samsung: exynos5420: Add clk save/restore registers
By the way, this patch only adds writes to registers that should be set
up before suspending the system and both the subject and description
should reflect this. Please be more careful when describing patches.
On 08.05.2014 12:53, Vikas Sajjan wrote:
> Adds clk save/restore registers for 5420
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
> index 60b2681..01fd917 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -101,6 +101,18 @@
> #define KPLL_CON0 0x28100
> #define SRC_KFC 0x28200
> #define DIV_KFC0 0x28500
> +#define SRC_MASK_CPERI 0x04300
> +#define SRC_MASK_TOP0 0x10300
> +#define SRC_MASK_TOP1 0x10304
> +#define SRC_MASK_TOP2 0x10308
> +#define SRC_MASK_TOP7 0x1031C
> +#define SRC_MASK_MAU 0x10334
> +#define SRC_MASK_FSYS 0x10340
> +#define SRC_MASK_PERIC0 0x10350
> +#define SRC_MASK_PERIC1 0x10354
> +#define SRC_MASK_ISP 0x10370
> +#define GATE_BUS_DISP1 0x10728
> +#define GATE_IP_PERIC 0x10950
Please sort the definitions according to addresses.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420
@ 2014-05-08 17:18 ` Tomasz Figa
0 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-05-08 17:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi Vikas,
Please try to more or less follow subsystem subject conventions. It
should be:
clk: samsung: exynos5420: Add clk save/restore registers
By the way, this patch only adds writes to registers that should be set
up before suspending the system and both the subject and description
should reflect this. Please be more careful when describing patches.
On 08.05.2014 12:53, Vikas Sajjan wrote:
> Adds clk save/restore registers for 5420
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
> index 60b2681..01fd917 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -101,6 +101,18 @@
> #define KPLL_CON0 0x28100
> #define SRC_KFC 0x28200
> #define DIV_KFC0 0x28500
> +#define SRC_MASK_CPERI 0x04300
> +#define SRC_MASK_TOP0 0x10300
> +#define SRC_MASK_TOP1 0x10304
> +#define SRC_MASK_TOP2 0x10308
> +#define SRC_MASK_TOP7 0x1031C
> +#define SRC_MASK_MAU 0x10334
> +#define SRC_MASK_FSYS 0x10340
> +#define SRC_MASK_PERIC0 0x10350
> +#define SRC_MASK_PERIC1 0x10354
> +#define SRC_MASK_ISP 0x10370
> +#define GATE_BUS_DISP1 0x10728
> +#define GATE_IP_PERIC 0x10950
Please sort the definitions according to addresses.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-08 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 10:53 [PATCH V3 3/3] CLK: EXYNOS: Add clk save/restore registers for 5420 Vikas Sajjan
2014-05-08 10:53 ` Vikas Sajjan
2014-05-08 17:18 ` Tomasz Figa
2014-05-08 17:18 ` Tomasz Figa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.