From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-032.synserver.de ([212.40.185.32]:1236 "EHLO smtp-out-016.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753705AbaEHRb7 (ORCPT ); Thu, 8 May 2014 13:31:59 -0400 Message-ID: <536BBF78.7080100@metafoo.de> Date: Thu, 08 May 2014 19:31:36 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Alexandre Belloni CC: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Josh Wu , Jonathan Cameron , Maxime Ripard Subject: Re: [PATCH 2/2] iio:adc: at91 requires the input subsystem References: <1399560433-1402630-1-git-send-email-arnd@arndb.de> <1399560990-1402858-1-git-send-email-arnd@arndb.de> <1399560990-1402858-13-git-send-email-arnd@arndb.de> <20140508172243.GC6095@piout.net> In-Reply-To: <20140508172243.GC6095@piout.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 05/08/2014 07:22 PM, Alexandre Belloni wrote: > Hi, > > On 08/05/2014 at 16:56:24 +0200, Arnd Bergmann wrote : >> Building the at91 adc driver with CONFIG_INPUT disabled results in this >> build error: >> >> ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! >> >> To make sure we can build random configurations, this turns on CONFIG_INPUT >> whenever CONFIG_AT91_ADC is enabled. >> > > I'm wondering wether we should make part of the driver compile only if > CONFIG_INPUT is defined. Maybe some user will want to use the ADC and > not have any input on their board. > > What do you think ? > This typically just leads to more build errors. E.g. if INPUT is defined as a module, but AT91_ADC is build in. I think it is very rare to see a configuration without INPUT set, other then a randconfig. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Thu, 08 May 2014 19:31:36 +0200 Subject: [PATCH 2/2] iio:adc: at91 requires the input subsystem In-Reply-To: <20140508172243.GC6095@piout.net> References: <1399560433-1402630-1-git-send-email-arnd@arndb.de> <1399560990-1402858-1-git-send-email-arnd@arndb.de> <1399560990-1402858-13-git-send-email-arnd@arndb.de> <20140508172243.GC6095@piout.net> Message-ID: <536BBF78.7080100@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/08/2014 07:22 PM, Alexandre Belloni wrote: > Hi, > > On 08/05/2014 at 16:56:24 +0200, Arnd Bergmann wrote : >> Building the at91 adc driver with CONFIG_INPUT disabled results in this >> build error: >> >> ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! >> ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! >> >> To make sure we can build random configurations, this turns on CONFIG_INPUT >> whenever CONFIG_AT91_ADC is enabled. >> > > I'm wondering wether we should make part of the driver compile only if > CONFIG_INPUT is defined. Maybe some user will want to use the ADC and > not have any input on their board. > > What do you think ? > This typically just leads to more build errors. E.g. if INPUT is defined as a module, but AT91_ADC is build in. I think it is very rare to see a configuration without INPUT set, other then a randconfig. - Lars