diff for duplicates of <536C2A1C.6030807@samsung.com> diff --git a/a/1.txt b/N1/1.txt index d402663..a4b95b2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -38,7 +38,7 @@ On 04/26/2014 09:51 AM, Tomasz Figa wrote: >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >> Cc: Kumar Gala <galak@codeaurora.org> >> Cc: Russell King <linux@arm.linux.org.uk> ->> Cc: devicetree@vger.kernel.org +>> Cc: devicetree at vger.kernel.org >> --- >> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++ >> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++ @@ -69,14 +69,14 @@ On 04/26/2014 09:51 AM, Tomasz Figa wrote: >> +*/ >> + >> +/ { ->> + pinctrl@11400000 { +>> + pinctrl at 11400000 { > > Could you use references instead of re-specifying the whole tree hierarchy in every file a node is used? > > Instead of > > / { -> pinctrl@11400000 { +> pinctrl at 11400000 { > > }; > }; @@ -298,7 +298,7 @@ OK, I'll change it. >> + }; >> + }; >> + ->> + pinctrl@11000000 { +>> + pinctrl at 11000000 { >> + gpe0: gpe0 { >> + gpio-controller; >> + #gpio-cells = <2>; @@ -607,7 +607,7 @@ OK, I'll change it. >> + #address-cells = <1>; >> + #size-cells = <0>; >> + ->> + cpu@0 { +>> + cpu at 0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a7"; >> + reg = <0>; @@ -631,7 +631,7 @@ or Documentation/devicetree/bindings/arm/cpus.txt. >> + #address-cells = <1>; >> + #size-cells = <0>; >> + ->> + xusbxti: clock@0 { +>> + xusbxti: clock at 0 { >> + compatible = "fixed-clock"; >> + reg = <0>; >> + clock-frequency = <0>; @@ -639,7 +639,7 @@ or Documentation/devicetree/bindings/arm/cpus.txt. >> + clock-output-names = "xusbxti"; >> + }; >> + ->> + xxti: clock@1 { +>> + xxti: clock at 1 { >> + compatible = "fixed-clock"; >> + reg = <1>; >> + clock-frequency = <0>; @@ -647,7 +647,7 @@ or Documentation/devicetree/bindings/arm/cpus.txt. >> + clock-output-names = "xxti"; >> + }; >> + ->> + xtcxo: clock@2 { +>> + xtcxo: clock at 2 { >> + compatible = "fixed-clock"; >> + reg = <2>; >> + clock-frequency = <0>; @@ -656,54 +656,54 @@ or Documentation/devicetree/bindings/arm/cpus.txt. >> + }; >> + }; >> + ->> + chipid@10000000 { +>> + chipid at 10000000 { >> + compatible = "samsung,exynos4210-chipid"; >> + reg = <0x10000000 0x100>; >> + }; >> + ->> + sys_reg: syscon@10010000 { +>> + sys_reg: syscon at 10010000 { >> + compatible = "samsung,exynos3-sysreg", "syscon"; >> + reg = <0x10010000 0x400>; >> + }; >> + ->> + pd_cam: cam-power-domain@10023C00 { +>> + pd_cam: cam-power-domain at 10023C00 { >> + compatible = "samsung,exynos4210-pd"; >> + reg = <0x10023C00 0x20>; >> + }; >> + ->> + pd_mfc: mfc-power-domain@10023C40 { +>> + pd_mfc: mfc-power-domain at 10023C40 { >> + compatible = "samsung,exynos4210-pd"; >> + reg = <0x10023C40 0x20>; >> + }; >> + ->> + pd_g3d: g3d-power-domain@10023C60 { +>> + pd_g3d: g3d-power-domain at 10023C60 { >> + compatible = "samsung,exynos4210-pd"; >> + reg = <0x10023C60 0x20>; >> + }; >> + ->> + pd_lcd0: lcd0-power-domain@10023C80 { +>> + pd_lcd0: lcd0-power-domain at 10023C80 { >> + compatible = "samsung,exynos4210-pd"; >> + reg = <0x10023C80 0x20>; >> + }; >> + ->> + pd_isp: isp-power-domain@10023CA0 { +>> + pd_isp: isp-power-domain at 10023CA0 { >> + compatible = "samsung,exynos4210-pd"; >> + reg = <0x10023CA0 0x20>; >> + }; >> + ->> + cmu: clock-controller@10030000 { +>> + cmu: clock-controller at 10030000 { >> + compatible = "samsung,exynos3250-cmu"; >> + reg = <0x10030000 0x20000>; >> + #clock-cells = <1>; >> + }; >> + ->> + rtc@10070000 { +>> + rtc at 10070000 { > > Please add label to the node, so it can be referenced from board dts files added later (using the method I explained above). OK, I'll add lable as following: - rtc_0: rtc@10070000 { + rtc_0: rtc at 10070000 { > >> + compatible = "samsung,s3c6410-rtc"; @@ -712,7 +712,7 @@ OK, I'll add lable as following: >> + status = "disabled"; >> + }; >> + ->> + gic: interrupt-controller@10481000 { +>> + gic: interrupt-controller at 10481000 { >> + compatible = "arm,cortex-a15-gic"; >> + #interrupt-cells = <3>; >> + interrupt-controller; @@ -723,7 +723,7 @@ OK, I'll add lable as following: >> + interrupts = <1 9 0xf04>; >> + }; >> + ->> + mct@10050000 { +>> + mct at 10050000 { >> + compatible = "samsung,exynos4210-mct"; >> + reg = <0x10050000 0x800>; >> + interrupts = <0 218 0>, <0 219 0>, <0 220 0>, <0 221 0>, @@ -732,7 +732,7 @@ OK, I'll add lable as following: >> + clock-names = "fin_pll", "mct"; >> + }; >> + ->> + pinctrl_1: pinctrl@11000000 { +>> + pinctrl_1: pinctrl at 11000000 { >> + compatible = "samsung,exynos3250-pinctrl"; >> + reg = <0x11000000 0x1000>; >> + interrupts = <0 225 0>; @@ -744,13 +744,13 @@ OK, I'll add lable as following: >> + }; >> + }; >> + ->> + pinctrl_0: pinctrl@11400000 { +>> + pinctrl_0: pinctrl at 11400000 { >> + compatible = "samsung,exynos3250-pinctrl"; >> + reg = <0x11400000 0x1000>; >> + interrupts = <0 240 0>; >> + }; >> + ->> + mshc_0: mshc@12510000 { +>> + mshc_0: mshc at 12510000 { >> + compatible = "samsung,exynos5250-dw-mshc"; >> + reg = <0x12510000 0x1000>; >> + interrupts = <0 142 0>; @@ -762,7 +762,7 @@ OK, I'll add lable as following: >> + status = "disabled"; >> + }; >> + ->> + mshc_1: mshc@12520000 { +>> + mshc_1: mshc at 12520000 { >> + compatible = "samsung,exynos5250-dw-mshc"; >> + reg = <0x12520000 0x1000>; >> + interrupts = <0 143 0>; @@ -781,7 +781,7 @@ OK, I'll add lable as following: >> + interrupt-parent = <&gic>; >> + ranges; >> + ->> + pdma0: pdma@12680000 { +>> + pdma0: pdma at 12680000 { >> + compatible = "arm,pl330", "arm,primecell"; >> + reg = <0x12680000 0x1000>; >> + interrupts = <0 138 0>; @@ -792,7 +792,7 @@ OK, I'll add lable as following: >> + #dma-requests = <32>; >> + }; >> + ->> + pdma1: pdma@12690000 { +>> + pdma1: pdma at 12690000 { >> + compatible = "arm,pl330", "arm,primecell"; >> + reg = <0x12690000 0x1000>; >> + interrupts = <0 139 0>; @@ -804,7 +804,7 @@ OK, I'll add lable as following: >> + }; >> + }; >> + ->> + adc: adc@126C0000 { +>> + adc: adc at 126C0000 { >> + compatible = "samsung,exynos-adc-v3"; >> + reg = <0x126C0000 0x100>, <0x10020718 0x4>; >> + interrupts = <0 137 0>; @@ -815,13 +815,13 @@ OK, I'll add lable as following: >> + status = "disabled"; >> + }; >> + ->> + serial@13800000 { +>> + serial at 13800000 { > > Please add label. OK, I'll add lable as following: - serial_0: serial@13800000 { + serial_0: serial at 13800000 { > >> + compatible = "samsung,exynos4210-uart"; @@ -832,11 +832,11 @@ OK, I'll add lable as following: >> + status = "disabled"; >> + }; >> + ->> + serial@13810000 { +>> + serial at 13810000 { OK, I'll add lable as following: - serial_1: serial@13800000 { + serial_1: serial at 13800000 { Thanks for your review. diff --git a/a/content_digest b/N1/content_digest index 9b7ffec..5d8a3ca 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,38 +1,10 @@ "ref\01398388572-30239-1-git-send-email-cw00.choi@samsung.com\0" "ref\01398388572-30239-8-git-send-email-cw00.choi@samsung.com\0" "ref\0535B0324.50705@gmail.com\0" - "From\0Chanwoo Choi <cw00.choi@samsung.com>\0" - "Subject\0Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250\0" + "From\0cw00.choi@samsung.com (Chanwoo Choi)\0" + "Subject\0[PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250\0" "Date\0Fri, 09 May 2014 10:06:36 +0900\0" - "To\0Tomasz Figa <tomasz.figa@gmail.com>\0" - "Cc\0kgene.kim@samsung.com" - t.figa@samsung.com - linux-kernel@vger.kernel.org - linux@arm.linux.org.uk - ben-linux@fluff.org - arnd@arndb.de - olof@lixom.net - marc.zyngier@arm.com - thomas.abraham@linaro.org - kyungmin.park@samsung.com - inki.dae@samsung.com - sw0312.kim@samsung.com - hyunhee.kim@samsung.com - yj44.cho@samsung.com - chanho61.park@samsung.com - sajjan.linux@gmail.com - tushar.behera@linaro.org - sachin.kamat@linaro.org - linux-samsung-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - devicetree@vger.kernel.org - Jaehoon Chung <jh80.chung@samsung.com> - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - Rob Herring <robh+dt@kernel.org> - Pawel Moll <pawel.moll@arm.com> - Mark Rutland <mark.rutland@arm.com> - Ian Campbell <ijc+devicetree@hellion.org.uk> - " Kumar Gala <galak@codeaurora.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Tomasz,\n" @@ -75,7 +47,7 @@ ">> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>\n" ">> Cc: Kumar Gala <galak@codeaurora.org>\n" ">> Cc: Russell King <linux@arm.linux.org.uk>\n" - ">> Cc: devicetree@vger.kernel.org\n" + ">> Cc: devicetree at vger.kernel.org\n" ">> ---\n" ">> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++\n" ">> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++\n" @@ -106,14 +78,14 @@ ">> +*/\n" ">> +\n" ">> +/ {\n" - ">> + pinctrl@11400000 {\n" + ">> + pinctrl at 11400000 {\n" "> \n" "> Could you use references instead of re-specifying the whole tree hierarchy in every file a node is used?\n" "> \n" "> Instead of\n" "> \n" "> / {\n" - "> pinctrl@11400000 {\n" + "> pinctrl at 11400000 {\n" "> \n" "> };\n" "> };\n" @@ -335,7 +307,7 @@ ">> + };\n" ">> + };\n" ">> +\n" - ">> + pinctrl@11000000 {\n" + ">> + pinctrl at 11000000 {\n" ">> + gpe0: gpe0 {\n" ">> + gpio-controller;\n" ">> + #gpio-cells = <2>;\n" @@ -644,7 +616,7 @@ ">> + #address-cells = <1>;\n" ">> + #size-cells = <0>;\n" ">> +\n" - ">> + cpu@0 {\n" + ">> + cpu at 0 {\n" ">> + device_type = \"cpu\";\n" ">> + compatible = \"arm,cortex-a7\";\n" ">> + reg = <0>;\n" @@ -668,7 +640,7 @@ ">> + #address-cells = <1>;\n" ">> + #size-cells = <0>;\n" ">> +\n" - ">> + xusbxti: clock@0 {\n" + ">> + xusbxti: clock at 0 {\n" ">> + compatible = \"fixed-clock\";\n" ">> + reg = <0>;\n" ">> + clock-frequency = <0>;\n" @@ -676,7 +648,7 @@ ">> + clock-output-names = \"xusbxti\";\n" ">> + };\n" ">> +\n" - ">> + xxti: clock@1 {\n" + ">> + xxti: clock at 1 {\n" ">> + compatible = \"fixed-clock\";\n" ">> + reg = <1>;\n" ">> + clock-frequency = <0>;\n" @@ -684,7 +656,7 @@ ">> + clock-output-names = \"xxti\";\n" ">> + };\n" ">> +\n" - ">> + xtcxo: clock@2 {\n" + ">> + xtcxo: clock at 2 {\n" ">> + compatible = \"fixed-clock\";\n" ">> + reg = <2>;\n" ">> + clock-frequency = <0>;\n" @@ -693,54 +665,54 @@ ">> + };\n" ">> + };\n" ">> +\n" - ">> + chipid@10000000 {\n" + ">> + chipid at 10000000 {\n" ">> + compatible = \"samsung,exynos4210-chipid\";\n" ">> + reg = <0x10000000 0x100>;\n" ">> + };\n" ">> +\n" - ">> + sys_reg: syscon@10010000 {\n" + ">> + sys_reg: syscon at 10010000 {\n" ">> + compatible = \"samsung,exynos3-sysreg\", \"syscon\";\n" ">> + reg = <0x10010000 0x400>;\n" ">> + };\n" ">> +\n" - ">> + pd_cam: cam-power-domain@10023C00 {\n" + ">> + pd_cam: cam-power-domain at 10023C00 {\n" ">> + compatible = \"samsung,exynos4210-pd\";\n" ">> + reg = <0x10023C00 0x20>;\n" ">> + };\n" ">> +\n" - ">> + pd_mfc: mfc-power-domain@10023C40 {\n" + ">> + pd_mfc: mfc-power-domain at 10023C40 {\n" ">> + compatible = \"samsung,exynos4210-pd\";\n" ">> + reg = <0x10023C40 0x20>;\n" ">> + };\n" ">> +\n" - ">> + pd_g3d: g3d-power-domain@10023C60 {\n" + ">> + pd_g3d: g3d-power-domain at 10023C60 {\n" ">> + compatible = \"samsung,exynos4210-pd\";\n" ">> + reg = <0x10023C60 0x20>;\n" ">> + };\n" ">> +\n" - ">> + pd_lcd0: lcd0-power-domain@10023C80 {\n" + ">> + pd_lcd0: lcd0-power-domain at 10023C80 {\n" ">> + compatible = \"samsung,exynos4210-pd\";\n" ">> + reg = <0x10023C80 0x20>;\n" ">> + };\n" ">> +\n" - ">> + pd_isp: isp-power-domain@10023CA0 {\n" + ">> + pd_isp: isp-power-domain at 10023CA0 {\n" ">> + compatible = \"samsung,exynos4210-pd\";\n" ">> + reg = <0x10023CA0 0x20>;\n" ">> + };\n" ">> +\n" - ">> + cmu: clock-controller@10030000 {\n" + ">> + cmu: clock-controller at 10030000 {\n" ">> + compatible = \"samsung,exynos3250-cmu\";\n" ">> + reg = <0x10030000 0x20000>;\n" ">> + #clock-cells = <1>;\n" ">> + };\n" ">> +\n" - ">> + rtc@10070000 {\n" + ">> + rtc at 10070000 {\n" "> \n" "> Please add label to the node, so it can be referenced from board dts files added later (using the method I explained above).\n" "\n" "OK, I'll add lable as following:\n" "\n" - "\trtc_0: rtc@10070000 {\n" + "\trtc_0: rtc at 10070000 {\n" "\n" "> \n" ">> + compatible = \"samsung,s3c6410-rtc\";\n" @@ -749,7 +721,7 @@ ">> + status = \"disabled\";\n" ">> + };\n" ">> +\n" - ">> + gic: interrupt-controller@10481000 {\n" + ">> + gic: interrupt-controller at 10481000 {\n" ">> + compatible = \"arm,cortex-a15-gic\";\n" ">> + #interrupt-cells = <3>;\n" ">> + interrupt-controller;\n" @@ -760,7 +732,7 @@ ">> + interrupts = <1 9 0xf04>;\n" ">> + };\n" ">> +\n" - ">> + mct@10050000 {\n" + ">> + mct at 10050000 {\n" ">> + compatible = \"samsung,exynos4210-mct\";\n" ">> + reg = <0x10050000 0x800>;\n" ">> + interrupts = <0 218 0>, <0 219 0>, <0 220 0>, <0 221 0>,\n" @@ -769,7 +741,7 @@ ">> + clock-names = \"fin_pll\", \"mct\";\n" ">> + };\n" ">> +\n" - ">> + pinctrl_1: pinctrl@11000000 {\n" + ">> + pinctrl_1: pinctrl at 11000000 {\n" ">> + compatible = \"samsung,exynos3250-pinctrl\";\n" ">> + reg = <0x11000000 0x1000>;\n" ">> + interrupts = <0 225 0>;\n" @@ -781,13 +753,13 @@ ">> + };\n" ">> + };\n" ">> +\n" - ">> + pinctrl_0: pinctrl@11400000 {\n" + ">> + pinctrl_0: pinctrl at 11400000 {\n" ">> + compatible = \"samsung,exynos3250-pinctrl\";\n" ">> + reg = <0x11400000 0x1000>;\n" ">> + interrupts = <0 240 0>;\n" ">> + };\n" ">> +\n" - ">> + mshc_0: mshc@12510000 {\n" + ">> + mshc_0: mshc at 12510000 {\n" ">> + compatible = \"samsung,exynos5250-dw-mshc\";\n" ">> + reg = <0x12510000 0x1000>;\n" ">> + interrupts = <0 142 0>;\n" @@ -799,7 +771,7 @@ ">> + status = \"disabled\";\n" ">> + };\n" ">> +\n" - ">> + mshc_1: mshc@12520000 {\n" + ">> + mshc_1: mshc at 12520000 {\n" ">> + compatible = \"samsung,exynos5250-dw-mshc\";\n" ">> + reg = <0x12520000 0x1000>;\n" ">> + interrupts = <0 143 0>;\n" @@ -818,7 +790,7 @@ ">> + interrupt-parent = <&gic>;\n" ">> + ranges;\n" ">> +\n" - ">> + pdma0: pdma@12680000 {\n" + ">> + pdma0: pdma at 12680000 {\n" ">> + compatible = \"arm,pl330\", \"arm,primecell\";\n" ">> + reg = <0x12680000 0x1000>;\n" ">> + interrupts = <0 138 0>;\n" @@ -829,7 +801,7 @@ ">> + #dma-requests = <32>;\n" ">> + };\n" ">> +\n" - ">> + pdma1: pdma@12690000 {\n" + ">> + pdma1: pdma at 12690000 {\n" ">> + compatible = \"arm,pl330\", \"arm,primecell\";\n" ">> + reg = <0x12690000 0x1000>;\n" ">> + interrupts = <0 139 0>;\n" @@ -841,7 +813,7 @@ ">> + };\n" ">> + };\n" ">> +\n" - ">> + adc: adc@126C0000 {\n" + ">> + adc: adc at 126C0000 {\n" ">> + compatible = \"samsung,exynos-adc-v3\";\n" ">> + reg = <0x126C0000 0x100>, <0x10020718 0x4>;\n" ">> + interrupts = <0 137 0>;\n" @@ -852,13 +824,13 @@ ">> + status = \"disabled\";\n" ">> + };\n" ">> +\n" - ">> + serial@13800000 {\n" + ">> + serial at 13800000 {\n" "> \n" "> Please add label.\n" "\n" "OK, I'll add lable as following:\n" "\n" - "\tserial_0: serial@13800000 {\n" + "\tserial_0: serial at 13800000 {\n" "\n" "> \n" ">> + compatible = \"samsung,exynos4210-uart\";\n" @@ -869,11 +841,11 @@ ">> + status = \"disabled\";\n" ">> + };\n" ">> +\n" - ">> + serial@13810000 {\n" + ">> + serial at 13810000 {\n" "\n" "OK, I'll add lable as following:\n" "\n" - "\tserial_1: serial@13800000 {\n" + "\tserial_1: serial at 13800000 {\n" "\n" "\n" "Thanks for your review.\n" @@ -881,4 +853,4 @@ "Best regards,\n" Chanwoo Choi -3085d4fdfc839529ce66f83c598db27fcb1e433a25812719f67f566639b72059 +f94786ea8c04277e53ee7eaf8c0b1b4563cd3b17ac446b91b0cb53eb3298a1a6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.