All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lan Tianyu <tianyu.lan@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Stratos Karafotis <stratosk@semaphore.gr>,
	Lv Zheng <lv.zheng@intel.com>, Bob Moore <robert.moore@intel.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: linux-pm build failure
Date: Fri, 09 May 2014 09:45:27 +0800	[thread overview]
Message-ID: <536C3337.40402@intel.com> (raw)
In-Reply-To: <2930403.UViFFypGRj@vostro.rjw.lan>

On 2014年05月09日 03:44, Rafael J. Wysocki wrote:
> On Thursday, May 08, 2014 08:12:24 PM Stratos Karafotis wrote:
>> Hi all,
> 
> Hi,
> 
> Thanks for the report!
> 
> This is caused by commit
> 
> 0e23847d5ee4 ACPICA: Export acpi_buffer_to_resource symbol
> 
> merged on top of the recent ACPICA material.
> 
> Lv, Tianyu, care to take care of this?

Hi Rafael:
	Just check commit 51e35823eb57 and find it also exports
acpi_buffer_to_resource symbol which commit 0e23847d5ee4 has already
done. I think you can drop commit 0e23847d5ee4 which only exports symbol
without any other changes.

> 
>> There is a build failure in latest linux-pm bleeding-edge:
>>
>> In file included from include/linux/linkage.h:6:0,
>>                  from include/linux/kernel.h:6,
>>                  from include/acpi/platform/aclinux.h:64,
>>                  from include/acpi/platform/acenv.h:150,
>>                  from include/acpi/acpi.h:56,
>>                  from drivers/acpi/acpica/rscreate.c:44:
>> include/linux/export.h:59:20: error: redefinition of ‘__kstrtab_acpi_buffer_to_resource’
>>   static const char __kstrtab_##sym[]   \
>>                     ^
>> include/linux/export.h:69:2: note: in expansion of macro ‘__EXPORT_SYMBOL’
>>   __EXPORT_SYMBOL(sym, "")
>>   ^
>> include/acpi/platform/aclinux.h:110:37: note: in expansion of macro ‘EXPORT_SYMBOL’
>>  #define ACPI_EXPORT_SYMBOL(symbol)  EXPORT_SYMBOL(symbol);
>>                                      ^
>> drivers/acpi/acpica/rscreate.c:119:1: note: in expansion of macro ‘ACPI_EXPORT_SYMBOL’
>>  ACPI_EXPORT_SYMBOL(acpi_buffer_to_resource)
>>  ^
>> include/linux/export.h:59:20: note: previous definition of ‘__kstrtab_acpi_buffer_to_resource’ was here
>>   static const char __kstrtab_##sym[]   \
>>                     ^
>> include/linux/export.h:69:2: note: in expansion of macro ‘__EXPORT_SYMBOL’
>>   __EXPORT_SYMBOL(sym, "")
>>   ^
>> include/acpi/platform/aclinux.h:110:37: note: in expansion of macro ‘EXPORT_SYMBOL’
>>  #define ACPI_EXPORT_SYMBOL(symbol)  EXPORT_SYMBOL(symbol);
>>                                      ^
>> drivers/acpi/acpica/rscreate.c:117:1: note: in expansion of macro ‘ACPI_EXPORT_SYMBOL’
>>  ACPI_EXPORT_SYMBOL(acpi_buffer_to_resource);
>>  ^
>> include/linux/export.h:63:39: error: redefinition of ‘__ksymtab_acpi_buffer_to_resource’
>>   __visible const struct kernel_symbol __ksymtab_##sym \
>>                                        ^
>> include/linux/export.h:69:2: note: in expansion of macro ‘__EXPORT_SYMBOL’
>>   __EXPORT_SYMBOL(sym, "")
>>   ^
>> include/acpi/platform/aclinux.h:110:37: note: in expansion of macro ‘EXPORT_SYMBOL’
>>  #define ACPI_EXPORT_SYMBOL(symbol)  EXPORT_SYMBOL(symbol);
>>                                      ^
>> drivers/acpi/acpica/rscreate.c:119:1: note: in expansion of macro ‘ACPI_EXPORT_SYMBOL’
>>  ACPI_EXPORT_SYMBOL(acpi_buffer_to_resource)
>>  ^
>> include/linux/export.h:63:39: note: previous definition of ‘__ksymtab_acpi_buffer_to_resource’ was here
>>   __visible const struct kernel_symbol __ksymtab_##sym \
>>                                        ^
>> include/linux/export.h:69:2: note: in expansion of macro ‘__EXPORT_SYMBOL’
>>   __EXPORT_SYMBOL(sym, "")
>>   ^
>> include/acpi/platform/aclinux.h:110:37: note: in expansion of macro ‘EXPORT_SYMBOL’
>>  #define ACPI_EXPORT_SYMBOL(symbol)  EXPORT_SYMBOL(symbol);
>>                                      ^
>> drivers/acpi/acpica/rscreate.c:117:1: note: in expansion of macro ‘ACPI_EXPORT_SYMBOL’
>>  ACPI_EXPORT_SYMBOL(acpi_buffer_to_resource);
>>  ^
>> make[3]: *** [drivers/acpi/acpica/rscreate.o] Error 1
>> make[2]: *** [drivers/acpi/acpica] Error 2
>> make[1]: *** [drivers/acpi] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [drivers] Error 2
>>
>>
>> Reverting commit 51e35823eb57 ("ACPICA: Update acpi_buffer_to_resource interface"), build completes fine.
>>
>>
>> Thanks,
>> Stratos Karafotis
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Best regards
Tianyu Lan

  reply	other threads:[~2014-05-09  1:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 17:12 linux-pm build failure Stratos Karafotis
2014-05-08 19:44 ` Rafael J. Wysocki
2014-05-09  1:45   ` Lan Tianyu [this message]
2014-05-09 21:36     ` Rafael J. Wysocki
2014-05-10  6:22       ` Stratos Karafotis
2014-05-09  1:09 ` Zheng, Lv
2014-05-09  1:11 ` Zheng, Lv
2014-05-09  4:35   ` Stratos Karafotis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536C3337.40402@intel.com \
    --to=tianyu.lan@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=stratosk@semaphore.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.