Re: [PATCH] arm: exynos: add generic function to calculate cpu number

[Tomasz Figa <t.figa@samsung.com>]

Hi Chander,

On 09.05.2014 09:50, Chander Kashyap wrote:
> On 5 May 2014 09:37, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>> On 25 April 2014 11:14, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>>> The address of cpu power registers in pmu is based on cpu number
>>> offsets. This function calculate the same. This is essentially
>>> required in case of multicluster SoC's e.g Exynos5420.
>>>
>>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>>> Signed-off-by: Chander Kashyap <k.chander@samsung.com>
>>> ---
>>>  arch/arm/mach-exynos/regs-pmu.h |    9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-exynos/regs-pmu.h b/arch/arm/mach-exynos/regs-pmu.h
>>> index 4f6a256..217da2e 100644
>>> --- a/arch/arm/mach-exynos/regs-pmu.h
>>> +++ b/arch/arm/mach-exynos/regs-pmu.h
>>> @@ -313,4 +313,13 @@
>>>
>>>  #define EXYNOS5_OPTION_USE_RETENTION                           (1 << 4)
>>>
>>> +#include <asm/cputype.h>
>>> +#define MAX_CPUS_IN_CLUSTER    4
>>> +
>>> +static inline unsigned int exynos_pmu_cpunr(unsigned int mpidr)
>>> +{
>>> +       return ((MPIDR_AFFINITY_LEVEL(mpidr, 1) * MAX_CPUS_IN_CLUSTER)
>>> +                + MPIDR_AFFINITY_LEVEL(mpidr, 0));
>>> +}
>>> +
>>>  #endif /* __ASM_ARCH_REGS_PMU_H */
>>> --
>>> 1.7.9.5
>>>
>>
>> Kukjin, Can you please have a look.
>>
>>
>>
>> --
>> with warm regards,
>> Chander Kashyap
> Hi Kgene,
> Can you take this patch if no issues with it.

Is there any user for this function right now? Shouldn't this patch
rather be included as a part of some series that adds actual users of it?

Best regards,
Tomasz