From: Peter Krempa <pkrempa@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible
Date: Fri, 09 May 2014 14:55:23 +0200 [thread overview]
Message-ID: <536CD03B.804@redhat.com> (raw)
In-Reply-To: <20140509113946.GA26017@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On 05/09/14 13:39, Stefan Hajnoczi wrote:
> On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote:
...
>
> Please use scripts/checkpatch.pl to check coding style in the future. I
> added {} around the if statement body. QEMU always uses curlies even
> for 1-statement bodies.
Ah, right, sorry about that. I'm used to libvirt's coding style which
allows it. I'll use the patch checker next time.
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
Thanks.
>
> Stefan
>
Peter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
prev parent reply other threads:[~2014-05-09 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 10:08 [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible Peter Krempa
2014-05-09 11:39 ` Stefan Hajnoczi
2014-05-09 12:55 ` Peter Krempa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CD03B.804@redhat.com \
--to=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.