From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Huang Subject: Re: [RFC v3 2/6] xen/arm: Add save/restore support for ARM GIC V2 Date: Fri, 09 May 2014 09:12:15 -0500 Message-ID: <536CE23F.4030608@samsung.com> References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com> <1399583908-21755-3-git-send-email-w1.huang@samsung.com> <536C099C.1090606@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <536C099C.1090606@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, jaeyong.yoo@samsung.com, jbeulich@suse.com, yjhyun.yoo@samsung.com List-Id: xen-devel@lists.xenproject.org On 05/08/2014 05:47 PM, Andrew Cooper wrote: >> +DECLARE_HVM_SAVE_TYPE(GICH_V2, 3, struct hvm_arm_gich_v2); >> + >> /* >> * Largest type-code in use >> */ >> -#define HVM_SAVE_CODE_MAX 1 >> +#define HVM_SAVE_CODE_MAX 3 >> >> #endif >> > > On x86, we require that HVM save records only contain architectural > state. Not knowing arm myself, it is not clear from your comments > whether this is the case or not. Can you confirm whether it is or not? Most states are guest architecture states which include core registers, arch timer, memory. GIC states are arguable, given that Xen uses data structures (e.g. struct vgic_irq_rank) to represent GIC states internally. > > ~Andrew >