All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Gustavo Sverzut Barbieri <barbieri@gmail.com>
Subject: Re: [PATCH] depmod: Make dependency loops be fatal
Date: Fri, 09 May 2014 22:50:49 +0400	[thread overview]
Message-ID: <536D2389.7060800@gmail.com> (raw)
In-Reply-To: <20140509184502.GC584@intel.com>

09.05.2014 22:45, Lucas De Marchi пишет:
>> Do I understand you correctly that your patch fails to create modules.dep
> 
> I'd say it avoids losing the previous, valid modules.dep.

When building an RPM package, we don't have the previous one.

> This is what I'm arguing for... dependency loops are bugs in kernel
> modules that should rather be fixed instead of papering over.
> 
> Btw, I don't think they are that common since we never received a bug
> report about this in kmod. I'm open to people chiming in, claiming
> otherwise.

How about introducing --force switch or something like that to alter the
behavior in runtime?

For instance, the default is to fail, but with --force is to omit looped
modules.


  reply	other threads:[~2014-05-09 18:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 18:14 [PATCH] depmod: Make dependency loops be fatal Lucas De Marchi
     [not found] ` <CAJs94EbuDx4Wj4HEMjepc1s8a5oWKBp6Q1DOU53GuFx9RExCDg@mail.gmail.com>
2014-05-09 18:45   ` Lucas De Marchi
2014-05-09 18:50     ` Matwey V. Kornilov [this message]
2014-05-15  3:02 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536D2389.7060800@gmail.com \
    --to=matwey.kornilov@gmail.com \
    --cc=barbieri@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.