From: Owen Kirby <osk@exegin.com>
To: barebox@lists.infradead.org
Subject: [PATCH] Add readmem command to read values out of memory.
Date: Fri, 09 May 2014 15:59:11 -0700 [thread overview]
Message-ID: <536D5DBF.7040708@exegin.com> (raw)
From 299ffc6a961c807b118605bdd9e736c7b096fec9 Mon Sep 17 00:00:00 2001
From: Owen Kirby <osk@exegin.com>
Date: Fri, 9 May 2014 15:14:30 -0700
Subject: [PATCH] Add readmem command to read values out of memory.
I was trying to do something conditionally from a shell script based on the type
of image present in flash, and finding it rather cumbersome to do. So I added a
command that reads values out of memory and into shell variables as hexadecimal.
Signed-off-by: Owen Kirby <osk@exegin.com>
---
commands/Kconfig | 8 ++++
commands/Makefile | 1 +
commands/readmem.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 112 insertions(+)
create mode 100644 commands/readmem.c
diff --git a/commands/Kconfig b/commands/Kconfig
index cc014f3..52fa0df 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -367,6 +367,14 @@ config CMD_MEMSET
the memset command allows to set regions of memory and files to
a specific value.
+config CMD_READMEM
+ tristate
+ default y
+ select CMD_MEMORY
+ prompt "readmem"
+ help
+ the readmem command reads values from memory into a shell variable.
+
config CMD_CRC
tristate
select CRC32
diff --git a/commands/Makefile b/commands/Makefile
index e463031..a01e642 100644
--- a/commands/Makefile
+++ b/commands/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_CMD_MW) += mw.o
obj-$(CONFIG_CMD_MEMCMP) += memcmp.o
obj-$(CONFIG_CMD_MEMCPY) += memcpy.o
obj-$(CONFIG_CMD_MEMSET) += memset.o
+obj-$(CONFIG_CMD_READMEM) += readmem.o
obj-$(CONFIG_CMD_EDIT) += edit.o
obj-$(CONFIG_CMD_EXEC) += exec.o
obj-$(CONFIG_CMD_SLEEP) += sleep.o
diff --git a/commands/readmem.c b/commands/readmem.c
new file mode 100644
index 0000000..7070637
--- /dev/null
+++ b/commands/readmem.c
@@ -0,0 +1,103 @@
+/*
+ * (C) Copyright 2014
+ * Owen Kirby, Exegin Technologies Limited, osk@exegin.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include <common.h>
+#include <command.h>
+#include <init.h>
+#include <driver.h>
+#include <malloc.h>
+#include <errno.h>
+#include <fs.h>
+#include <fcntl.h>
+#include <getopt.h>
+#include <linux/stat.h>
+#include <xfuncs.h>
+#include <environment.h>
+
+extern char *mem_rw_buf;
+
+static int do_readmem(int argc, char *argv[])
+{
+ loff_t src;
+ int ret = 0;
+ int fd;
+ char *filename = "/dev/mem";
+ char *varname;
+ int mode = O_RWSIZE_4;
+ int swab = 0;
+
+ if (argc < 2)
+ return COMMAND_ERROR_USAGE;
+
+ if (mem_parse_options(argc, argv, "bwls:x", &mode, &filename, NULL,
+ &swab) < 0)
+ return 1;
+
+ if (optind + 2 > argc)
+ return COMMAND_ERROR_USAGE;
+
+ src = strtoull_suffix(argv[optind], NULL, 0);
+ varname = argv[optind+1];
+ fd = open_and_lseek(filename, mode | O_RDONLY, src);
+ if (fd < 0)
+ return 1;
+
+ /* Read the magic var. */
+ if (read(fd, mem_rw_buf, mode >> O_RWSIZE_SHIFT) < 0) {
+ perror("read");
+ ret = 1;
+ }
+ /* Set the environment variable. */
+ else if (mode == O_RWSIZE_4) {
+ u32 res = *(uint *)mem_rw_buf;
+ char buf[sizeof(res)*2+1];
+ sprintf(buf, "%08x", swab ? __swab32(res) : res);
+ setenv(varname, buf);
+ } else if (mode == O_RWSIZE_2) {
+ u16 res = *(ushort *)mem_rw_buf;
+ char buf[sizeof(res)*2+1];
+ sprintf(buf, "%04x", swab ? __swab16(res) : res);
+ setenv(varname, buf);
+ } else {
+ char buf[sizeof(u_char)*2+1];
+ sprintf(buf, "%02x", *(u_char *)mem_rw_buf);
+ setenv(varname, buf);
+ }
+ close(fd);
+ return ret;
+}
+
+static const __maybe_unused char cmd_readmem_help[] =
+"Usage: readmem [OPTIONS] <src> VAR\n"
+"\n"
+"options:\n"
+" -s <file> source file (default /dev/mem)\n"
+" -b read a byte\n"
+" -w read a halfword (16bit)\n"
+" -l read a word (32bit)\n"
+" -x swap bytes\n"
+"\n"
+"read a magic value from <src> into variable VAR.\n";
+
+BAREBOX_CMD_START(readmem)
+ .cmd = do_readmem,
+ .usage = "read magic values from memory",
+ BAREBOX_CMD_HELP(cmd_readmem_help)
+BAREBOX_CMD_END
+
--
1.7.9.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2014-05-09 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 22:59 Owen Kirby [this message]
2014-05-10 13:32 ` [PATCH] Add readmem command to read values out of memory Antony Pavlov
2014-05-12 5:59 ` Sascha Hauer
2014-05-12 18:36 ` Owen Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536D5DBF.7040708@exegin.com \
--to=osk@exegin.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.