From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiuZ0-0001N0-8u for qemu-devel@nongnu.org; Fri, 09 May 2014 19:50:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiuYv-00018U-1S for qemu-devel@nongnu.org; Fri, 09 May 2014 19:50:50 -0400 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:40400 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiuYu-00018F-T1 for qemu-devel@nongnu.org; Fri, 09 May 2014 19:50:44 -0400 Message-ID: <536D6994.2090404@comstyle.com> Date: Fri, 09 May 2014 19:49:40 -0400 From: Brad Smith MIME-Version: 1.0 References: <536B9900.2010108@comstyle.com> <536D5EA2.30307@comstyle.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] QEMU build broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , qemu-devel On 09/05/14 7:35 PM, Peter Maydell wrote: > On 10 May 2014 00:02, Brad Smith wrote: >> On 08/05/14 10:54 AM, Peter Maydell wrote: >>> Ah, bsd-user. Do you actually use it, or is it just >>> in the default compile that you're running? > >> I do not use it personally but it is common sense that commits >> must not be breaking the build. > > I generally agree, but the minor ports (roughly, anything > not x86 Linux) are inevitably going to get broken from time > to time, because not everybody has access to all those > systems to test on. bsd-user is particularly bad because > it is a large chunk of code only built for BSD and it's > not really maintained right now. (Hence my interest in > whether it actually has users or if we're just carrying > around a big lump of dead weight code.) This is just excuses and points out poor project process. There could easily be a staging branch to deal with this. > If we had a system that automatically tested all pull > requests on a full set of build systems and mailed the > list with the results, that would be nice, but we don't... > > thanks > -- PMM > -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.