All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reuben Farrelly <reuben@reub.net>
To: Jeff Layton <jlayton@poochiereds.net>, Dave Jones <davej@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org,
	swhiteho@redhat.com, ssorce@redhat.com
Subject: Re: [PATCH] locks: only validate the lock vs. f_mode in F_SETLK codepaths
Date: Sat, 10 May 2014 09:59:58 +1000	[thread overview]
Message-ID: <536D6BFE.7040203@reub.net> (raw)
In-Reply-To: <20140509141535.13926fb8@tlielax.poochiereds.net>

On 10/05/2014 4:15 AM, Jeff Layton wrote:
> Well spotted -- that was indeed unintentional. Fixed in my repo and in
> the code in -next, but I'll refrain from re-posting for now.
>
> Clearly, I need to roll some better file locking tests... ;)
>
> Thanks,

I've just applied the following 3 patches from Jeff's git repo on top of 
a vanilla 3.15-rc5:

09e558d9baa6416111bce8610c6bbd9a525ee057 [PATCH] locks: only validate 
the lock vs. f_mode in F_SETLK codepaths

e4bf5e2a931bdf053e5bcb72ec959ee151ef2aaf [PATCH] locks: ensure that 
fl_owner is always initialized properly in flock and lease codepaths

0e71bcb3ec5d8fba7e534d379ad69933ed6493e0 [PATCH] fs/locks.c: replace 
seq_printf by seq_puts

I can confirm that this fixes the problem - in that Samba now compiles 
through to completion.

Thanks for the fix!

Reuben



  reply	other threads:[~2014-05-10  0:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 16:21 [PATCH] locks: only validate the lock vs. f_mode in F_SETLK codepaths Jeff Layton
2014-05-09 18:07 ` Dave Jones
2014-05-09 18:15   ` Jeff Layton
2014-05-09 23:59     ` Reuben Farrelly [this message]
2014-05-12 16:17 ` [PATCH v2] " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536D6BFE.7040203@reub.net \
    --to=reuben@reub.net \
    --cc=bfields@fieldses.org \
    --cc=davej@redhat.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ssorce@redhat.com \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.