All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] fs: use our own mkpasswd when creating users
@ 2014-05-10 13:39 Yann E. MORIN
  2014-05-10 14:14 ` Romain Naour
  2014-05-11  8:51 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-05-10 13:39 UTC (permalink / raw)
  To: buildroot

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Export PATH=$(BR_PATH) so that our own mkpasswd is found before
any existing host-system one.

Reported-by: Romain Naour <romain.naour@openwide.fr>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Samuel Martin <s.martin49@gmail.com>
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/common.mk b/fs/common.mk
index 831365e..47199c7 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -83,7 +83,7 @@ ifneq ($$(ROOTFS_USERS_TABLES),)
 	cat $$(ROOTFS_USERS_TABLES) >> $(USERS_TABLE)
 endif
 	printf '$(subst $(sep),\n,$(PACKAGES_USERS))' >> $(USERS_TABLE)
-	$(TOPDIR)/support/scripts/mkusers $(USERS_TABLE) $(TARGET_DIR) >> $(FAKEROOT_SCRIPT)
+	PATH=$(BR_PATH) $(TOPDIR)/support/scripts/mkusers $(USERS_TABLE) $(TARGET_DIR) >> $(FAKEROOT_SCRIPT)
 	echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT)
 	chmod a+x $$(FAKEROOT_SCRIPT)
 	$$(HOST_DIR)/usr/bin/fakeroot -- $$(FAKEROOT_SCRIPT)
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] fs: use our own mkpasswd when creating users
  2014-05-10 13:39 [Buildroot] [PATCH] fs: use our own mkpasswd when creating users Yann E. MORIN
@ 2014-05-10 14:14 ` Romain Naour
  2014-05-11  8:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Romain Naour @ 2014-05-10 14:14 UTC (permalink / raw)
  To: buildroot

Hi Yann,

Le 10/05/2014 15:39, Yann E. MORIN a ?crit :
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Export PATH=$(BR_PATH) so that our own mkpasswd is found before
> any existing host-system one.
> 
> Reported-by: Romain Naour <romain.naour@openwide.fr>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Samuel Martin <s.martin49@gmail.com>
> ---
>  fs/common.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/common.mk b/fs/common.mk
> index 831365e..47199c7 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -83,7 +83,7 @@ ifneq ($$(ROOTFS_USERS_TABLES),)
>  	cat $$(ROOTFS_USERS_TABLES) >> $(USERS_TABLE)
>  endif
>  	printf '$(subst $(sep),\n,$(PACKAGES_USERS))' >> $(USERS_TABLE)
> -	$(TOPDIR)/support/scripts/mkusers $(USERS_TABLE) $(TARGET_DIR) >> $(FAKEROOT_SCRIPT)
> +	PATH=$(BR_PATH) $(TOPDIR)/support/scripts/mkusers $(USERS_TABLE) $(TARGET_DIR) >> $(FAKEROOT_SCRIPT)
>  	echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT)
>  	chmod a+x $$(FAKEROOT_SCRIPT)
>  	$$(HOST_DIR)/usr/bin/fakeroot -- $$(FAKEROOT_SCRIPT)
> 

Tested-by: Romain Naour <romain.naour@openwide.fr>

Tested on Fedora host which has an incompatible version of mkpasswd.

Best regards,
Romain Naour

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] fs: use our own mkpasswd when creating users
  2014-05-10 13:39 [Buildroot] [PATCH] fs: use our own mkpasswd when creating users Yann E. MORIN
  2014-05-10 14:14 ` Romain Naour
@ 2014-05-11  8:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-05-11  8:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Export PATH=$(BR_PATH) so that our own mkpasswd is found before
 > any existing host-system one.

 > Reported-by: Romain Naour <romain.naour@openwide.fr>
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Samuel Martin <s.martin49@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-11  8:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-10 13:39 [Buildroot] [PATCH] fs: use our own mkpasswd when creating users Yann E. MORIN
2014-05-10 14:14 ` Romain Naour
2014-05-11  8:51 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.