From: "Petter Mabäcker" <petter@technux.se>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2 01/13] systemtap: remove usage of FILESPATH
Date: Sun, 11 May 2014 20:13:26 +0200 [thread overview]
Message-ID: <536FBDC6.4090806@technux.se> (raw)
In-Reply-To: <1399810380.31891.110.camel@ted>
On 05/11/2014 02:13 PM, Richard Purdie wrote:
> On Sun, 2014-05-11 at 00:31 +0200, petter@technux.se wrote:
>> 2014-05-10 18:58 skrev Khem Raj:
>>
>>> On Sat, May 10, 2014 at 1:05 AM, Petter Mabäcker <petter@technux.se>
>>> wrote:
>>>
>>>> +FILESEXTRAPATHS_prepend := "${THISDIR}/systemtap:"
>>> would something like
>>>
>>> FILESEXTRAPATHS =. "${FILE_DIRNAME}/systemtap:"
>>>
>>> avoid the prepend and immediate evaluation
>> I guess someone with deep bitbake knowledge can answer this better. But
>> as far as I understand, you should always use immediate evaluation when
>> using THISDIR, to be extra safe. Not sure if it's more safe to use
>> FILE_DIRNAME if you want to avoid immediate expanding when using
>> FILESEXTRAPATHS?
>>
>> The bitbake documentations says:
>>
>> "The operators "_append" and "_prepend" differ from the operators ".="
>> and "=." in that they are deferred until after parsing completes rather
>> than being immediately applied."
>>
>> Not sure if above means that "=." will also immediately expand
>> variables or not?
> They're not.
>
>> Personally I have always used FILESEXTRAPATHS_prepend :=
>> "${THISDIR}/<somename>:" like the yocto documentation recommends. But
>> sure if you can avoid immediate expanding in FILESEXTRPATHS, that would
>> mean a tiny optimization. In that case perhaps the documentation should
>> be updated as well. Looking in meta-layer both methods seems to be used.
> What Khem means is that in the case we know we're in the .bb file
> directory, we can use FILE_DIRNAME instead of using :=.
>
> Why? FILE_DIRNAME is defined as:
>
> conf/bitbake.conf:FILE_DIRNAME = "${@os.path.dirname(d.getVar('FILE'))}"
>
> FILE will point to the .bb file.
>
> Cheers,
>
> Richard
>
>
>
Ok, that makes sense. I will send up a new changeset using this method
instead.
BR,
Petter
next prev parent reply other threads:[~2014-05-11 18:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 8:06 [PATCHv2 00/13] Remove usage of FILESPATH Petter Mabäcker
2014-05-10 8:05 ` [PATCHv2 01/13] systemtap: remove " Petter Mabäcker
2014-05-10 16:58 ` Khem Raj
2014-05-10 22:31 ` petter
2014-05-10 23:49 ` Khem Raj
2014-05-11 12:13 ` Richard Purdie
2014-05-11 18:13 ` Petter Mabäcker [this message]
2014-05-10 8:05 ` [PATCHv2 02/13] dbus: " Petter Mabäcker
2014-05-10 8:05 ` [PATCHv2 03/13] gstreamer: remove unused FILESPATH Petter Mabäcker
2014-05-10 8:05 ` [PATCHv2 04/13] trace-cmd: refactoring recipe Petter Mabäcker
2014-05-10 8:05 ` [PATCHv2 05/13] xorg-lib: remove usage of FILESPATH Petter Mabäcker
2014-05-10 8:05 ` [PATCHv2 06/13] mesa: " Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 07/13] qemu: remove unused FILESPATH Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 08/13] linuxdoc-tools: remove usage of FILESPATH Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 09/13] gcc: " Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 10/13] python: " Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 11/13] u-boot: remove unused FILESPATH Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 12/13] uclibc: remove usage of FILESPATH Petter Mabäcker
2014-05-10 8:06 ` [PATCHv2 13/13] eglibc: " Petter Mabäcker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536FBDC6.4090806@technux.se \
--to=petter@technux.se \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.