From: zhuyj <zyjzyj2000@gmail.com>
To: eric.dumazet@gmail.com, "David S. Miller" <davem@davemloft.net>
Cc: "Tao, Yue" <Yue.Tao@windriver.com>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
zhuyj <zyjzyj2000@gmail.com>
Subject: Re: icmp: account for ICMP out errors because of socket limit
Date: Mon, 12 May 2014 12:48:10 +0800 [thread overview]
Message-ID: <5370528A.1000806@gmail.com> (raw)
In-Reply-To: <53703DC0.2070204@gmail.com>
Hi, Eric && David
This patch is similar to the following patch.
commit 1f8438a853667d48055ad38384c63e94b32c6578
Author: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat Apr 3 15:09:04 2010 -0700
icmp: Account for ICMP out errors
When ip_append() fails because of socket limit or memory shortage,
increment ICMP_MIB_OUTERRORS counter, so that "netstat -s" can report
these errors.
LANG=C netstat -s | grep "ICMP messages failed"
0 ICMP messages failed
For IPV6, implement ICMP6_MIB_OUTERRORS counter as well.
# grep Icmp6OutErrors /proc/net/dev_snmp6/*
/proc/net/dev_snmp6/eth0:Icmp6OutErrors 0
/proc/net/dev_snmp6/lo:Icmp6OutErrors 0
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Best Regards!
Zhu Yanjun
On 05/12/2014 11:19 AM, zhuyj wrote:
> Hi, Eric && David
>
> ____ ______________
> | | | |
> | PC |<------->| MIPS 32 core |
> |____| |______________|
>
> When ping from a PC to a board (MIPS 32 core), because of socket limit,
> ping echo will fail. But ICMP_MIB_OUTERRORS counter is not incremented.
> In this case, "netstat -s" can not report these errors.
>
> This patch will fix this problem. Now it is in the attachment. Please
> check it.
>
> Best Regards!
> Zhu Yanjun
next prev parent reply other threads:[~2014-05-12 4:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 3:19 icmp: account for ICMP out errors because of socket limit zhuyj
2014-05-12 4:48 ` zhuyj [this message]
2014-05-14 18:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370528A.1000806@gmail.com \
--to=zyjzyj2000@gmail.com \
--cc=Yue.Tao@windriver.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.