From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjkwc-0006WK-J6 for qemu-devel@nongnu.org; Mon, 12 May 2014 03:46:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjkwR-0001cu-Sw for qemu-devel@nongnu.org; Mon, 12 May 2014 03:46:42 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:53154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjkwR-0001cp-Kz for qemu-devel@nongnu.org; Mon, 12 May 2014 03:46:31 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 May 2014 08:46:30 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 080501B08040 for ; Mon, 12 May 2014 08:46:42 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4C7kSrx53215476 for ; Mon, 12 May 2014 07:46:28 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4C7kRvu013322 for ; Mon, 12 May 2014 01:46:28 -0600 Message-ID: <53707C53.5030001@de.ibm.com> Date: Mon, 12 May 2014 09:46:27 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1399485959-15579-1-git-send-email-mjrosato@linux.vnet.ibm.com> In-Reply-To: <1399485959-15579-1-git-send-email-mjrosato@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] s390: Support for Hotplug of Standby Memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato , qemu-devel@nongnu.org Cc: agraf@suse.de, aliguori@amazon.com, imammedo@redhat.com, Cornelia Huck , pbonzini@redhat.com, rth@twiddle.net On 07/05/14 20:05, Matthew Rosato wrote: > This patchset adds support in s390 for a pool of standby memory, > which can be set online/offline by the guest (ie, via chmem). > New options, maxmem and slots, are added to the QEMU command line > memory parameter to specify the total amount of memory available > to the guest as well as the number of memory slots available. > As part of this work, additional results are provided for the > Read SCP Information SCLP, and new implentation is added for the > Read Storage Element Information, Attach Storage Element, > Assign Storage and Unassign Storage SCLPs, which enables the s390 > guest to manipulate the standby memory pool. > > This patchset is based on work originally done by Jeng-Fang (Nick) > Wang. > > Changes for v3: > * Remove some patches shared with ACPI memory hotplug that are now > applied to master > * Fix in sclp.h to avoid compiler error for s390x-linux-user mode > * Fix in s390-virtio-ccw.c to avoid checking the value of > mhd->increment_size before it's been set with a meaningful > value. > * Add MAX_STORAGE_INCREMENTS > > Changes for v2: > * Removed the patch that introduced the standby-mem operand and > instead included Igor Mammedov's patches that add the mem-opts > 'maxmem' and 'slots', with a slight modification due to the removal > of qemu_opts_create_nofail. > * Patch 3 was inserted to add a new qom object that encapsulate variables > used by s390 memory hotplug. Patches 4 and 5 adjusted to use this > object. > * Added additional code comments and other minor changes per Alexander > Graf's comments > > Igor Mammedov (1): > vl.c: extend -m option to support options for memory hotplug > > Matthew Rosato (3): > sclp-s390: Add device to manage s390 memory hotplug > virtio-ccw: Include standby memory when calculating storage increment > sclp-s390: Add memory hotplug SCLPs > > hw/s390x/s390-virtio-ccw.c | 44 +++++-- > hw/s390x/sclp.c | 277 ++++++++++++++++++++++++++++++++++++++++++-- > include/hw/boards.h | 2 + > include/hw/s390x/sclp.h | 19 +++ > qemu-options.hx | 9 +- > target-s390x/cpu.h | 18 +++ > target-s390x/kvm.c | 5 + > vl.c | 51 ++++++++ > 8 files changed, 407 insertions(+), 18 deletions(-) > I think the patch set is shaping up quite well. two things: 1. I had some small comments to the patches, please have a look 2. Igor, what are your plans on pushing the first patch (and implement hotplug for x86) Could you push patch1 independently from the other patches?