From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Huang Subject: Re: [RFC v3 5/6] xen/arm: Add log_dirty support for ARM Date: Mon, 12 May 2014 09:00:12 -0500 Message-ID: <5370D3EC.80005@samsung.com> References: <1399583908-21755-1-git-send-email-w1.huang@samsung.com> <1399583908-21755-6-git-send-email-w1.huang@samsung.com> <536F9707.4060807@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <536F9707.4060807@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xen.org Cc: keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jaeyong.yoo@samsung.com, jbeulich@suse.com, ian.jackson@eu.citrix.com, yjhyun.yoo@samsung.com List-Id: xen-devel@lists.xenproject.org On 05/11/2014 10:28 AM, Julien Grall wrote: > the guest very soon. With this > solution there is a 1GB hole between the 2 banks. Your function will therefore > stop to work. > > Furthermore, Xen should not assume that the layout of the guest will always start > at GUEST_RAM_BASE. > > I think you can use max_mapped_pfn and lowest_mapped_pfn here. You may need to > modify a bit the signification of it in the p2m code or introduce a new field. These two values don't work for the purpose of dirty tracking. What we need are two fields to track _physical_ memory. lowest_mapped_pfn tracks all memory types, which doesn't apply here. Will new fields to track physical ram space acceptable for you? -Wei