From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WjsAv-0003ZF-QT
	for qemu-devel@nongnu.org; Mon, 12 May 2014 11:30:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WjsAn-0005AX-En
	for qemu-devel@nongnu.org; Mon, 12 May 2014 11:29:57 -0400
Message-ID: <5370E8EA.9020407@suse.de>
Date: Mon, 12 May 2014 17:29:46 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1399887940-13676-1-git-send-email-Bharat.Bhushan@freescale.com>
	<1399887940-13676-3-git-send-email-Bharat.Bhushan@freescale.com>
In-Reply-To: <1399887940-13676-3-git-send-email-Bharat.Bhushan@freescale.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2 v2] ppc-e500: implement PCI INTx routing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharat Bhushan <r65777@freescale.com>, mst@redhat.com, agraf@suse.de, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, scottwood@freescale.com
Cc: Bharat Bhushan <Bharat.Bhushan@freescale.com>

> diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
> index f672d5f..5ed59e8 100644
> --- a/hw/pci-host/ppce500.c
> +++ b/hw/pci-host/ppce500.c
[...]
> @@ -267,13 +269,26 @@ static int mpc85xx_pci_map_irq(PCIDevice *pci_dev=
, int pin)
> =20
>  static void mpc85xx_pci_set_irq(void *opaque, int pin, int level)
>  {
> -    qemu_irq *pic =3D opaque;
> +    PPCE500PCIState *s =3D opaque;
> +    qemu_irq *pic =3D s->irq;;

Double semicolon.

Regards,
Andreas


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg