From: Eric Sandeen <sandeen@sandeen.net>
To: Roger Willcocks <roger@filmlight.ltd.uk>, xfs@oss.sgi.com
Subject: Re: 'delete' parameter in xfs_ialloc.h
Date: Mon, 12 May 2014 10:31:48 -0500 [thread overview]
Message-ID: <5370E964.50805@sandeen.net> (raw)
In-Reply-To: <1399908138.4857.28.camel@montana.filmlight.ltd.uk>
On 5/12/14, 10:22 AM, Roger Willcocks wrote:
> Hi folks,
>
> I have to fix this up every time I update xfsprogs -
>
> The 'delete' parameter in xfsprogs/include/xfs_ialloc.c:xfs_difree(...)
> causes a compile error if the header's included in C++ code (even with
> 'extern "C"') -
>
> xfs_ialloc.h:102: error: expected ‘,’ or ‘...’ before ‘delete’
>
> (gcc 4.4.7)
>
> It would be handy if the parameter name could be commented out or
> changed in the header.
>
Send a patch? Would need to hit kernel code too.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-12 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 15:22 'delete' parameter in xfs_ialloc.h Roger Willcocks
2014-05-12 15:31 ` Eric Sandeen [this message]
2014-05-12 17:52 ` Roger Willcocks
2014-05-12 17:52 ` [PATCH] xfsprogs: fix compile error when libxfs header used in C++ code Roger Willcocks
2014-05-12 17:52 ` [PATCH] xfs: " Roger Willcocks
2014-05-19 22:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370E964.50805@sandeen.net \
--to=sandeen@sandeen.net \
--cc=roger@filmlight.ltd.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.