Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On 05/12/2014 10:36 AM, Kevin Wolf wrote:

>>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F
>>> backing_fmt] filename
>>
>> 'rebase' lacks -o; so it must continue to document -b.  This thread was
>> started in context to the 'create' subcommand, not the 'rebase'
>> subcommand.  (Arguably, we may need to add -o to rebase someday, but
>> that's not for this patch)
> 
> What would qemu-img rebase do with -o? It is just for (safely) changing
> the backing file, not for updating options. There is qemu-img amend for
> that, and it does have an -o option.

It's a consistency argument.  Why can't we have:

rebase -o backing_file=file,backing_fmt=fmt

similar to create, instead of having to treat rebase as the oddball
command that still takes separate options for two highly related items?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]