Re: [PATCH] can: mp251x: fix mcp2515 stops receiving problem

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On 05/12/2014 07:06 PM, Marc Kleine-Budde wrote:
> From: "Rost, Martin" <Martin.Rost@tonfunk.de>
> 
> The mcp2515 sometimes seems to trigger an interrupt with the corresponding
> register not being set yet. This makes the driver exit the interrupt because
> there is obviously nothing to do, but the interrupt line is kept low.
> Therefore the driver does not see any more interrupts until the chip is reset
> (via interface down/up).
> 
> This patch changes the IST to first check the IRQ registers, and wait up to 10
> ms if an event really occurrs. If the IRQ register is still empty after 10ms,
> a kernel message gets issued. The IST loop is rearranged to evaluate the IRQ
> register at the last moment before exiting, to not miss a late irq event.
> 
> Not-Signed-off-by: Martin Rost <Martin.Rost@tonfunk.de>

Martin, can I add your S-o-b [1]?

> Cc: Alexander Shiyan <shc_work@mail.ru>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

[1]
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L307

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]