All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: Waldemar Brodkorb <wbx@openadk.org>, linux-mips@linux-mips.org
Cc: florian@openwrt.org, nbd@openwrt.org, phil@nwl.cc
Subject: Re: pci problem with rb532
Date: Mon, 12 May 2014 21:24:13 +0200	[thread overview]
Message-ID: <53711FDD.6090905@openwrt.org> (raw)
In-Reply-To: <20140510213508.GC618@waldemar-brodkorb.de>

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi Waldemar,

> I recently had a need for a small DHCP/NFS server and resurvived my
> old Mikrotik RB532 board. Sadly the PCI registration is broken and
> the VIA Rhine network ports didn't work.
> See this thread for some details:
> https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg23073.html
> 
> I did know that it was working fine in the past, so I started to git
> bisect between 2.6.39 and 3.15-rc5.
> Following commit is the problem:
> commit 222831787704c9ad9215f6b56f975b233968607c
> Author: Gabor Juhos <juhosg@openwrt.org>
> Date:   Sat Feb 2 13:18:54 2013 +0000
> 
>     MIPS: avoid possible resource conflict in register_pci_controller
>     
>     The IO and memory resources of a PCI controller
>     might already have a parent resource set when
>     they are passed to 'register_pci_controller'.
>     
>     If the parent resource is set, the request_resource
>     call will fail due to resource conflict and the
>     current code will not be able to register the
>     PCI controller.
>     
>     Use the parent resource if it is available in the
>     request_resource call to avoid the isssue.
>     
>     Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>     Patchwork: http://patchwork.linux-mips.org/patch/4910/
>     Signed-off-by: John Crispin <blogic@openwrt.org>
> 
> After reverting the change, the VIA Rhine driver works fine again.
> 
> So how we can unbreak the rb532 support?

Please try the attached patch without reverting the aforementioned change.

Thanks,
Gabor



  reply	other threads:[~2014-05-12 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 21:35 pci problem with rb532 Waldemar Brodkorb
2014-05-12 19:24 ` Gabor Juhos [this message]
2014-05-14 14:08   ` Waldemar Brodkorb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53711FDD.6090905@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=nbd@openwrt.org \
    --cc=phil@nwl.cc \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.