All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: "Andreas Färber" <afaerber@suse.de>,
	"Bharat Bhushan" <r65777@freescale.com>,
	mst@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	scottwood@freescale.com
Cc: Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [Qemu-devel] [PATCH 2/2 v2] ppc-e500: implement PCI INTx routing
Date: Mon, 12 May 2014 22:29:19 +0200	[thread overview]
Message-ID: <53712F1F.3060909@suse.de> (raw)
In-Reply-To: <5370E8EA.9020407@suse.de>


On 12.05.14 17:29, Andreas Färber wrote:
>> diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
>> index f672d5f..5ed59e8 100644
>> --- a/hw/pci-host/ppce500.c
>> +++ b/hw/pci-host/ppce500.c
> [...]
>> @@ -267,13 +269,26 @@ static int mpc85xx_pci_map_irq(PCIDevice *pci_dev, int pin)
>>   
>>   static void mpc85xx_pci_set_irq(void *opaque, int pin, int level)
>>   {
>> -    qemu_irq *pic = opaque;
>> +    PPCE500PCIState *s = opaque;
>> +    qemu_irq *pic = s->irq;;
> Double semicolon.

Thanks, fixed in my tree :).


Alex

  reply	other threads:[~2014-05-12 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  9:45 [Qemu-devel] [PATCH 0/2 v2] ppc-e500: Adding pci-pin to irq callback and some cleanup Bharat Bhushan
2014-05-12  9:45 ` [Qemu-devel] [PATCH 1/2 v2] ppc-e500: some pci related cleanup Bharat Bhushan
2014-05-12  9:45 ` [Qemu-devel] [PATCH 2/2 v2] ppc-e500: implement PCI INTx routing Bharat Bhushan
2014-05-12 15:29   ` Andreas Färber
2014-05-12 20:29     ` Alexander Graf [this message]
2014-05-12 12:59 ` [Qemu-devel] [PATCH 0/2 v2] ppc-e500: Adding pci-pin to irq callback and some cleanup Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53712F1F.3060909@suse.de \
    --to=agraf@suse.de \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=afaerber@suse.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=r65777@freescale.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.