From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WjzPX-0000aH-Fq
	for qemu-devel@nongnu.org; Mon, 12 May 2014 19:13:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WjzPO-0000CW-FS
	for qemu-devel@nongnu.org; Mon, 12 May 2014 19:13:31 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:42187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WjzPO-0000CS-A7
	for qemu-devel@nongnu.org; Mon, 12 May 2014 19:13:22 -0400
Received: by mail-qc0-f178.google.com with SMTP id l6so8807343qcy.9
	for <qemu-devel@nongnu.org>; Mon, 12 May 2014 16:13:21 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5371558E.8000101@twiddle.net>
Date: Mon, 12 May 2014 16:13:18 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1398713302-29657-1-git-send-email-rth@twiddle.net>	<1398713302-29657-16-git-send-email-rth@twiddle.net>
	<CAFEAcA98xoR-41qSeEqN4AUHGKRvRotvjyQtppiuaMNGSwzmQg@mail.gmail.com>
In-Reply-To: <CAFEAcA98xoR-41qSeEqN4AUHGKRvRotvjyQtppiuaMNGSwzmQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 15/16] tci: Define
	TCG_TARGET_INSN_UNIT_SIZE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, QEMU Developers <qemu-devel@nongnu.org>

On 05/09/2014 06:52 AM, Peter Maydell wrote:
> though I note there are a number of functions that
> use the pattern
> 
>     uint8_t *old_code_ptr = s->code_ptr;
>     [...emit stuff...]
>     old_code_ptr[1] = s->code_ptr - old_code_ptr;
> 
> which could perhaps use tcg_insn_unit * rather than uint8_t * ?

Yes, probably.  There are quite a few changes I'd like to make to tci...


r~