All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
Date: Tue, 13 May 2014 07:30:10 +0200	[thread overview]
Message-ID: <5371ADE2.8010807@mind.be> (raw)
In-Reply-To: <1399911369-3165-1-git-send-email-oscar.hellstrom@vinnter.se>

On 12/05/14 18:16, Oscar Hellstr?m wrote:
> Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
> ---
>  package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 9fcda2e..9321f08 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
>  endef
>  endif
>  
> +ifeq ($(BR2_PACKAGE_READLINE),y)
> +	WPA_SUPPLICANT_DEPENDENCIES += readline
> +	WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE

 In package .mk file, we don't indent within if... constructs; we only use
indentation for commands and for continuation lines. I admit that that coding
style is objectionable, but it is what it is.

 Regards,
 Arnout

> +endif
> +
>  define WPA_SUPPLICANT_CONFIGURE_CMDS
>  	cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
>  	sed -i $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2014-05-13  5:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 16:16 [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli Oscar Hellström
2014-05-12 22:20 ` Gustavo Zacarias
2014-05-13  5:30 ` Arnout Vandecappelle [this message]
2014-05-13  7:28   ` Peter Korsgaard
2014-05-13  7:27 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5371ADE2.8010807@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.