From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2] xen-blkback: defer freeing blkif to
 avoid blocking xenwatch
Date: Tue, 13 May 2014 10:32:36 +0100
Message-ID: <5371E6B4.6040301@citrix.com>
References: <1399678479-14758-1-git-send-email-vali.priescu@gmail.com>
	<1399922737-10741-1-git-send-email-vali.priescu@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1399922737-10741-1-git-send-email-vali.priescu@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Valentin Priescu <vali.priescu@gmail.com>, xen-devel@lists.xensource.com
Cc: Valentin Priescu <priescuv@amazon.com>, Matt Wilson <msw@amazon.com>
List-Id: xen-devel@lists.xenproject.org

On 12/05/14 20:25, Valentin Priescu wrote:
> From: Valentin Priescu <priescuv@amazon.com>
> 
> Currently xenwatch blocks in VBD disconnect, waiting for all pending I/O
> requests to finish. If the VBD is attached to a hot-swappable disk, then
> xenwatch can hang for a long period of time, stalling other watches.
> 
[...]
> 
> With this patch, when there is still pending I/O, the actual disconnect
> is done by the last reference holder (last pending I/O request). In this
> case, xenwatch doesn't block indefinitely.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

> Signed-off-by: Valentin Priescu <priescuv@amazon.com>
> Reviewed-by: Steven Kady <stevkady@amazon.com>
> Reviewed-by: Steven Noonan <snoonan@amazon.com>
> Acked-by: Matt Wilson <msw@amazon.com>

Not sure Acked-by by a non-maintainer makes much sense. Matt, did you
mean Reviewed-by here instead?

David