From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkAKm-0001Up-7e for qemu-devel@nongnu.org; Tue, 13 May 2014 06:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkAKe-0007vp-KS for qemu-devel@nongnu.org; Tue, 13 May 2014 06:53:20 -0400 Received: from thoth.sbs.de ([192.35.17.2]:49078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkAKe-0007vD-As for qemu-devel@nongnu.org; Tue, 13 May 2014 06:53:12 -0400 Message-ID: <5371F990.30604@siemens.com> Date: Tue, 13 May 2014 12:53:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1399964954-10842-1-git-send-email-zhen-hual@hp.com> In-Reply-To: <1399964954-10842-1-git-send-email-zhen-hual@hp.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Support more than 255 cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Zhen-Hua" , qemu-devel@nongnu.org, Igor Mammedov , Eduardo Habkost On 2014-05-13 09:09, Li, Zhen-Hua wrote: > From: "Li, ZhenHua" > > These series patches are trying to make Qemu support more than 255 CPUs. > The max cpu number changed to 4096. > > Support more than 255 cpus: ACPI and APIC defines > Support more than 255 cpus: max_cpus to 4096 > Support more than 255 cpus: max cpumask bit to 4096 > Support more than 255 cpus: runtime chec > > include/hw/acpi/cpu_hotplug_defs.h | 4 ++-- > include/hw/i386/apic_internal.h | 2 +- > include/hw/i386/pc.h | 2 +- > include/sysemu/sysemu.h | 2 +- > hw/i386/acpi-build.c | 8 ++++---- Don't we need x2APIC support to provide >255 CPUs? Where so you enforce this, i.e. keep the restriction to 255 CPUs when we are not in KVM mode with in-kernel APIC (the emulate APIC lacks x2APIC mode, unfortunately)? But, wait, KVM only supports up to 255 VCPUs. So what are you targeting at? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux