From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 6/9] tools: arm: prepare domain builder
 for multiple banks of guest RAM
Date: Tue, 13 May 2014 13:21:58 +0100
Message-ID: <53720E66.1090200@linaro.org>
References: <1399980488.21867.19.camel@kazak.uk.xensource.com>
	<1399980574-12515-6-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1399980574-12515-6-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: ian.jackson@eu.citrix.com, tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 05/13/2014 12:29 PM, Ian Campbell wrote:
> +    /* Convenient */
>      const uint64_t kernbase = dom->kernel_seg.vstart;
>      const uint64_t kernend = ROUNDUP(dom->kernel_seg.vend, 21/*2MB*/);
>      const uint64_t kernsize = kernend - kernbase;
> @@ -298,20 +302,32 @@ int arch_setup_meminit(struct xc_dom_image *dom)
>      const uint64_t ramdisk_size = dom->ramdisk_blob ?
>          ROUNDUP(dom->ramdisk_size, XC_PAGE_SHIFT) : 0;
>      const uint64_t modsize = dtb_size + ramdisk_size;
> -    const uint64_t ram128mb = rambase + (128<<20);
> +    const uint64_t ram128mb = GUEST_RAM0_BASE + (128<<20);

I would use bankbase[0] here for more clarity.

[..]

> @@ -321,6 +337,20 @@ int arch_setup_meminit(struct xc_dom_image *dom)
>  
>      dom->shadow_enabled = 1;
>  
> +    for (i = 0; ramsize && i < GUEST_RAM_BANKS; i++)

for ( ... )

[..]

>      /* setup initial p2m and allocate guest memory */
> -    if ((rc = populate_guest_memory(dom,
> -                                    GUEST_RAM_BASE >> XC_PAGE_SHIFT,
> -                                    ramsize >> XC_PAGE_SHIFT)))
> -        return rc;
> +    for (i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++)

for ( ... )

Regards,

-- 
Julien Grall